Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 4.0 and Python 3.10 support #528

Merged
merged 15 commits into from
Jun 4, 2022
Merged

Django 4.0 and Python 3.10 support #528

merged 15 commits into from
Jun 4, 2022

Conversation

ElSaico
Copy link
Contributor

@ElSaico ElSaico commented Mar 21, 2022

Closes #462 (needed to upgrade pytest because of pytest-dev/pytest#8546)
Closes #465 (removed all pytz-isms and fixed incompatibilities with django-timezone-field 5.0)
Closes #518 (was one of such pytz-isms)

@ElSaico ElSaico changed the title Django 4.0 support Django 4.0 and Python 3.10 support Mar 21, 2022
t/proj/urls.py Outdated Show resolved Hide resolved
requirements/default.txt Show resolved Hide resolved
@ElSaico ElSaico requested a review from auvipy March 23, 2022 13:27
@auvipy
Copy link
Member

auvipy commented Mar 23, 2022

mu only concern is does django below 4 supoort zoneinfo?

@nourselim0
Copy link

my only concern is does django below 4 support zoneinfo?

According to this: https://docs.djangoproject.com/en/4.0/releases/4.0/#zoneinfo-default-timezone-implementation
Django 3.2 was the first version to support non-pytz time zones, which I assume means that it would support zoneinfo.
This means you'll need to update the dependency from >=2.2 to >=3.2.

.travis.yml Outdated
env:
- DJANGO=2.2
- DJANGO=3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our travis CI don't work anymore, I am working on moving to github actions

@auvipy auvipy added this to the v2.3.0 milestone Apr 3, 2022
@nickmccullum
Copy link

Any update on this? This is blocking us from upgrading one of our projects to Django 4, and we would love to get it merged.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rebase

ElSaico added 4 commits April 21, 2022 17:21
# Conflicts:
#	.travis.yml
#	requirements/test.txt
#	setup.py
#	t/proj/urls.py
#	t/unit/test_models.py
#	tox.ini
@ElSaico ElSaico requested a review from auvipy April 21, 2022 16:42
@auvipy
Copy link
Member

auvipy commented Apr 21, 2022

builds are failing

@ElSaico
Copy link
Contributor Author

ElSaico commented Apr 22, 2022

The build errors seem to be related to RabbitMQ being down during tests - except for the 3.8 one, which seems to call the 3.9 executable (and obviously fail) for whatever reason.

@tremechus
Copy link

@ElSaico checking in, looks like there is a rebase request in order to move this forward, is that something you can push?

@ElSaico
Copy link
Contributor Author

ElSaico commented Jun 3, 2022

@auvipy Made a number of fixes in GitHub Actions, including stuff that breaks on master already.

The only things broken now are the Sphinx builds, because of this:

Warning, treated as error:
  extlinks: Sphinx-6.0 will require a caption string to contain exactly one '%s' and all other '%' need to be escaped as '%%'.

I've fixed the entries on conf.py, but it seems like sphinx_celery has the same problem anyway. Thus we have two choices:

  • Drop -W from the sphinx-build calls, avoiding erroring out on warnings
  • Fix the extlinks entries in sphinx_celery

@auvipy
Copy link
Member

auvipy commented Jun 4, 2022

  • Fix the extlinks entries in sphinx_celery

Fix the extlinks entries in sphinx_celery -- should be the go :)

@auvipy
Copy link
Member

auvipy commented Jun 4, 2022

python 3.8 builds seems to be a github network issue

@auvipy auvipy merged commit d549016 into celery:master Jun 4, 2022
@auvipy
Copy link
Member

auvipy commented Jun 4, 2022

we can fix the sphinx issues in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants