Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PeriodicTaskAdmin list display #621

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Update PeriodicTaskAdmin list display #621

merged 3 commits into from
Feb 7, 2023

Conversation

khanh96le
Copy link
Contributor

PR for issue #620

@khanh96le khanh96le changed the title #620: Update PeriodicTaskAdmin list display Update PeriodicTaskAdmin list display Dec 22, 2022
@khanh96le khanh96le marked this pull request as ready for review December 23, 2022 02:21
auvipy
auvipy reviewed Feb 3, 2023
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you describe what does the change do?

@khanh96le khanh96le closed this Feb 6, 2023
@khanh96le khanh96le reopened this Feb 6, 2023
@khanh96le
Copy link
Contributor Author

@auvipy
I described the proposed changes in this issue: #620

To make it more clear, you can see the image below. I think the schedule (which is currently mixed with the task name) should have its own column.

From
Screen Shot 2023-02-06 at 15 34 25

To
Screen Shot 2023-02-06 at 15 39 00

@auvipy
Copy link
Member

auvipy commented Feb 6, 2023

can you check this PR as well #622?

@khanh96le
Copy link
Contributor Author

Seem like the #622 PR already covers the changes in my PR.
Therefore, I will close this one, and review #622 instead.

@khanh96le khanh96le closed this Feb 7, 2023
@khanh96le khanh96le mentioned this pull request Feb 7, 2023
Merged
@auvipy auvipy reopened this Feb 7, 2023
@auvipy auvipy merged commit 5680798 into celery:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khanh96le @auvipy