Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: Change assert self.app.timezone.zone to assert self.app.timezone.key #664

Merged
merged 6 commits into from
Jul 16, 2023

Conversation

stasfilin
Copy link
Contributor

Good afternoon,
This Pull Request is a quick fix for CI.

The error message AttributeError: 'zoneinfo.ZoneInfo' object has no attribute 'zone'

So, we can use
self.app.timezone.key

assert self.app.timezone.zone  to assert self.app.timezone.key

Signed-off-by: Stanislav Filin <stasfilin@hotmail.com>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Stanislav Filin <stasfilin@hotmail.com>
Signed-off-by: Stanislav Filin <stasfilin@hotmail.com>
@stasfilin stasfilin mentioned this pull request Jul 13, 2023
@auvipy
Copy link
Member

auvipy commented Jul 15, 2023

thanks for the PR. will merge after CI is green

@stasfilin
Copy link
Contributor Author

@auvipy Good morning

I see that the lint is failed

Failed to reach any of the inventories with the following issues:

  intersphinx inventory 'https://celery.readthedocs.io/en/master/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: 404 Client Error: Not Found for URL: https://docs.celeryq.dev/en/mastethe lint is failed 



This one is strange. Do you know the new URL that we need to use?

Thanks

@auvipy
Copy link
Member

auvipy commented Jul 15, 2023

Signed-off-by: Stanislav Filin <stasfilin@hotmail.com>
Signed-off-by: Stanislav Filin <stasfilin@hotmail.com>
docs/conf.py:43:80: E501 line too long (80 > 79 characters)

Signed-off-by: Stanislav Filin <stasfilin@hotmail.com>
@stasfilin
Copy link
Contributor Author

@auvipy Hi again, I did changes

image image

@auvipy auvipy self-requested a review July 15, 2023 09:49
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all green. thanks Stanislav

@auvipy auvipy merged commit 90b27d2 into celery:main Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants