Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release v2.6.0 to support Py3.12 and Dj5.0 #712

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 10, 2024

Fixes: #698
Fixes: #711

A release to PyPI is required to add support for Python v3.12 and Django v5.0. See: #698 (comment)

@cclauss cclauss mentioned this pull request Jan 10, 2024
Changelog Outdated
Comment on lines 13 to 14
release-date: !!! FIX_ME !!!
:release-by: !!! FIX_ME !!!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cclauss,

Please help me understand, are these dynamically generated?

Copy link
Contributor Author

@cclauss cclauss Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a project maintainer so I do not know if there are tools for the dynamic generation of release notes.

I merely looked at previous entries in this file and at https://github.com/celery/django-celery-beat/releases and then manually built this similar content. If maintainers have a better approach then this might go in the trash bin.

Thanks for your review (the checkmark in the upper right of this page). I wish more visitors would take that approach because it is usually more convincing to project maintainers than scads of 👍 and 🚀 emojis.

Copy link

@50-Course 50-Course left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cclauss,

Thank for pulling in this patch and to everyone who contributed to its discussion. This LGTM 🚀

Changelog Outdated Show resolved Hide resolved
Changelog Show resolved Hide resolved
@cclauss
Copy link
Contributor Author

cclauss commented Jan 11, 2024

@thedrow @auvipy Are other modifications (docs?, other?) required for a release?

@auvipy auvipy merged commit 1da72d6 into celery:main Jan 11, 2024
9 checks passed
@cclauss cclauss deleted the v2.6.0 branch January 11, 2024 10:44
@adampl
Copy link

adampl commented Jan 13, 2024

Hi, when do you plan the release? I can't wait :)

@cclauss
Copy link
Contributor Author

cclauss commented Jan 13, 2024

#680 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Django 5.0.1) AttributeError at /admin/django_celery_beat/crontabschedule/add/ django 5.0
5 participants