Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements/runtime.txt: Django>=2.2,<6.0 #792

Merged
merged 1 commit into from
Aug 23, 2024
+1 −1
Merged

requirements/runtime.txt: Django>=2.2,<6.0 #792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/runtime.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Django>=2.2,<5.2
Django>=2.2,<6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Django>=2.2,<6.0
Django>=2.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want another

Copy link

@ivan-klass ivan-klass Aug 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want another

@cclauss you're referencing a breaking change of major version , but <6.0 allows minor bump, which is usually safe.
I can't imagine django breaking changes in minor version within 5.x branch

Copy link
Contributor

@Mogost Mogost Aug 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss ^^ This problem could have been fixed by the end user with the use of monkey patching. User had a choice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivan-klass Please re-read the full commit message.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivan-klass Please re-read the full commit message.

Ahh, right! Sorry, I was lost in the discussion. I was looking forward for 5.2 compatible release, but don't want to block in case 5.3 and 5.4 next time. I'm not that experience for a strict opinion here, I would refer to best practices - i.e. how well-known django-based libraries do.