-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-1006: Revert #954 and update redis-py to at least 3.2.0 #1011
Conversation
This reverts celery#954, and bumps the required redis-py dependency to 3.2.0 to include this fix: redis/redis-py@4e1e748 Fixes celery#1006
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
+ Coverage 88.61% 88.68% +0.07%
==========================================
Files 63 63
Lines 6576 6569 -7
Branches 788 787 -1
==========================================
- Hits 5827 5826 -1
+ Misses 666 661 -5
+ Partials 83 82 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
+ Coverage 88.61% 88.68% +0.07%
==========================================
Files 63 63
Lines 6576 6569 -7
Branches 788 787 -1
==========================================
- Hits 5827 5826 -1
+ Misses 666 661 -5
+ Partials 83 82 -1
Continue to review full report at Codecov.
|
Personally I favour this solution over #1012 because it's cleaner. But realize that bumping the minimum required version of redis-py can be problematic for any number of reasons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I guess we have to bump the minimum version. Thanks a lot for the contributions. |
I mean there’s always the #1012 approach, but it adds technical debt to Kombu instead. |
Solution proposal 1 to fix #1006. See #1012 proposal 2.
This reverts #954, and bumps the required redis-py dependency to 3.2.0 to include this fix: redis/redis-py@4e1e748
Fixes #1006