Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Google Pub/Sub as transport broker #2147

Merged
merged 20 commits into from
Oct 13, 2024
Merged

Add support for Google Pub/Sub as transport broker #2147

merged 20 commits into from
Oct 13, 2024

Conversation

haimjether
Copy link
Contributor

Add support for GCP Pub/Sub

  • Add tests
  • Add docs

Fix: #705
Fix: celery/celery#3984

@haimjether haimjether changed the title Haim/feature/gcp pubsub on master Add support for GCP Pub/Sub transport Oct 12, 2024
@haimjether haimjether changed the title Add support for GCP Pub/Sub transport Add support for Google Pub/Sub as transport broker Oct 12, 2024
@haimjether haimjether marked this pull request as ready for review October 12, 2024 12:42
@haimjether haimjether marked this pull request as draft October 12, 2024 13:13
@haimjether haimjether marked this pull request as ready for review October 12, 2024 13:30
@haimjether haimjether mentioned this pull request Oct 12, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.87192% with 33 lines in your changes missing coverage. Please review.

Project coverage is 80.99%. Comparing base (5a88a28) to head (bcacfba).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kombu/transport/gcpubsub.py 91.87% 19 Missing and 14 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2147      +/-   ##
==========================================
+ Coverage   80.50%   80.99%   +0.48%     
==========================================
  Files          76       77       +1     
  Lines        9179     9585     +406     
  Branches     1125     1168      +43     
==========================================
+ Hits         7390     7763     +373     
- Misses       1601     1620      +19     
- Partials      188      202      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Nusnus
Nusnus requested changes Oct 12, 2024
View reviewed changes
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI failures 🙏

Nusnus
Nusnus requested changes Oct 12, 2024
View reviewed changes
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please change back to draft until the CI fully passes.
Feel free to ping me when it's ready for review!

@haimjether haimjether marked this pull request as draft October 12, 2024 16:05
@haimjether
Copy link
Contributor Author

Please fix CI failures 🙏

@Nusnus , I can't re-trigger those without maintainer approval :(

@haimjether haimjether marked this pull request as ready for review October 13, 2024 04:52
@haimjether
Copy link
Contributor Author

Also please change back to draft until the CI fully passes. Feel free to ping me when it's ready for review!

ping :)

@haimjether
Copy link
Contributor Author

My bad - I have last tiny nit,
would you mind if I push it ?

@Nusnus
Copy link
Member

Nusnus commented Oct 13, 2024

My bad - I have last tiny nit,
would you mind if I push it ?

Go for it 💯

Nusnus
Nusnus approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great contribution!
Amazing work, end to end.

Well done 💯👏

tox.ini Show resolved Hide resolved
@Nusnus Nusnus merged commit 2f58823 into celery:main Oct 13, 2024
37 checks passed
@Nusnus
Copy link
Member

Nusnus commented Oct 13, 2024

I'm going to release a new version soon.
Anything else required on the Kombu side? @haimjether

@haimjether
Copy link
Contributor Author

@Nusnus ,
kombu's off the hook (for now) :)

However this one celery/celery#9351
pretty mandatory for Flower to work correctly and is at Celery playground.

@haimjether haimjether deleted the haim/feature/gcp_pubsub_on_master branch October 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nusnus Nusnus Nusnus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Cloud Pub/Sub as a Broker - Hypothetically Possible? Has anyone looked into Cloud Pub/Sub?
3 participants
@haimjether @Nusnus @haim0n