Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't brpop if closed #2154

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

don't brpop if closed #2154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e0f8b5
don't brpop if closed
thuibr Oct 14, 2024
dc49dd2
Revert "don't brpop if closed"
thuibr Oct 14, 2024
b6eea5f
change test
thuibr Oct 21, 2024
5dbfb47
rm code
thuibr Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions kombu/transport/redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,11 +1087,6 @@ def _purge(self, queue):

def close(self):
self._closing = True
if self._in_poll:
try:
self._brpop_read()
except Empty:
pass
if not self.closed:
# remove from channel poller.
self.connection.cycle.discard(self)
Expand Down
2 changes: 1 addition & 1 deletion t/unit/transport/test_redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1451,7 +1451,7 @@ def test_close_in_poll(self):
c = Connection(transport=Transport).channel()
conn1 = c.client.connection
conn1._sock.data = [('BRPOP', ('test_Redis',))]
c._in_poll = True
c._in_poll = conn1
c.close()
assert conn1.disconnected
assert conn1._sock.data == []
Expand Down
Loading