Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a unit test that proves timeout is used when retry policy is specified #2166

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

thedrow
Copy link
Member

@thedrow thedrow commented Oct 20, 2024

No description provided.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.47%. Comparing base (6a77355) to head (82bf9ba).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2166   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files          77       77           
  Lines        9500     9500           
  Branches     1148     1148           
=======================================
  Hits         7740     7740           
  Misses       1569     1569           
  Partials      191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but the my comment from the confirm publish PR also applies here.

The test doesn’t check the actual functionality. It only confirms the arguments are passed as expected.
In this case, adding the unit test is great, in opposition to the other PR, so the PR is easily approved. However, please note that a higher-level test is required to confirm that the timeout is actually respected as expected. This unit test is not trustworthy enough.

You will need to test the negative flows to confirm that it works, which means passing the timeout and testing that it behaves as expected, based on the timeout value.

@Nusnus Nusnus merged commit 2a206a1 into celery:main Oct 20, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants