Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-code requests version because of the bug in docker-py #432

Merged
merged 1 commit into from
May 29, 2024

Conversation

awmackowiak
Copy link
Contributor

Due to bug reported in decker-py there is a need to hard-code the requests version to <=2.31.0.
5 days ago they released the newest version and the integration tests started failures that day.

@Nusnus Nusnus self-requested a review May 28, 2024 07:39
@Nusnus
Copy link
Member

Nusnus commented May 28, 2024

The bug is fixed in docker-py 7.1.0.
I think it's better to upgrade that instead of limiting requests instead 🙏 @awmackowiak

@Nusnus
Copy link
Member

Nusnus commented May 28, 2024

The bug is fixed in docker-py 7.1.0.
I think it's better to upgrade that instead of limiting requests instead 🙏 @awmackowiak

This is because newer versions of requests will never fix it so we either limit requests forever or just use the newest docker-py

@Nusnus
Copy link
Member

Nusnus commented May 29, 2024

The bug is fixed in docker-py 7.1.0.
I think it's better to upgrade that instead of limiting requests instead 🙏 @awmackowiak

This is because newer versions of requests will never fix it so we either limit requests forever or just use the newest docker-py

I am getting confused 4real…
I’ve tried to follow up on my own comment: #433
Nothing works, not even close.

I don’t like limiting requests, but we might not have any other choice at the moment, especially if this issue is relevant to fixing the Redis bug.

@Nusnus
Copy link
Member

Nusnus commented May 29, 2024

The bug is fixed in docker-py 7.1.0.
I think it's better to upgrade that instead of limiting requests instead 🙏 @awmackowiak

This is because newer versions of requests will never fix it so we either limit requests forever or just use the newest docker-py

I am getting confused 4real… I’ve tried to follow up on my own comment: #433 Nothing works, not even close.

I don’t like limiting requests, but we might not have any other choice at the moment, especially if this issue is relevant to fixing the Redis bug.

I also tried it with kombu, juts for the sake of seeing what happens.
Same confusing results: celery/kombu#2010

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing custom
HTTPAdapters will need to migrate their code to use this new API.
get_connection is considered deprecated in all versions of Requests>=2.32.0.

This is probably broken in more places and will take some time to fix across the board.

CleanShot 2024-05-29 at 20 03 41

Requests 2.32+ appears to have had a bumpy road regardless:
CleanShot 2024-05-29 at 20 06 02

Taking into consideration everything, I give it my approval.
That being said, we will need to revisit this issue again to allow upgrading everything.

@awmackowiak @auvipy

@Nusnus Nusnus merged commit ec138c2 into celery:main May 29, 2024
12 of 13 checks passed
@awmackowiak
Copy link
Contributor Author

@Nusnus
I also tried to find a silver bullet for that problem but didn't find an easy way to get the test up and running.
Kudos for the try :)

@Nusnus
Copy link
Member

Nusnus commented Nov 12, 2024

Taking into consideration everything, I give it my approval.
That being said, we will need to revisit this issue again to allow upgrading everything.

It looks like it still requires more attention #442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants