-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard-code requests version because of the bug in docker-py #432
Conversation
The bug is fixed in docker-py 7.1.0. |
This is because newer versions of requests will never fix it so we either limit requests forever or just use the newest docker-py |
I am getting confused 4real… I don’t like limiting requests, but we might not have any other choice at the moment, especially if this issue is relevant to fixing the Redis bug. |
I also tried it with kombu, juts for the sake of seeing what happens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing custom
HTTPAdapters will need to migrate their code to use this new API.
get_connection is considered deprecated in all versions of Requests>=2.32.0.
This is probably broken in more places and will take some time to fix across the board.
Requests 2.32+ appears to have had a bumpy road regardless:
Taking into consideration everything, I give it my approval.
That being said, we will need to revisit this issue again to allow upgrading everything.
@Nusnus |
)" This reverts commit ec138c2.
It looks like it still requires more attention #442 |
Due to bug reported in decker-py there is a need to hard-code the requests version to <=2.31.0.
5 days ago they released the newest version and the integration tests started failures that day.