-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Max
and MinSquareSize
as a parameter to the payment module
#183
Comments
Note: |
yeah, we still need to add this as a parameter. At the time of making this, it was unclear if we wanted to leave it as a constant to force a hardfork or if we want a param that can be changed by over two thirds of the voting power via the gov module. Now we want the latter. |
MaxSquareSize
as a parameter to the payment moduleMaxSquareSize
as a parameter to the payment module
While we're at it, we should also add the min square size as a param |
MaxSquareSize
as a parameter to the payment moduleMax
and MinSquareSize
as a parameter to the payment module
Adds `minSquareSize` and `maxSquareSize` as params to the payment module. Defines relevant stores and queries Relevant changes in `proto/payment/*` `x/payment/keeper*` `x/payment/types/*` - [x] closes #183 Note: The constants that currently define min/max square size have not been deprecated, will do so in another PR
Adds `minSquareSize` and `maxSquareSize` as params to the payment module. Defines relevant stores and queries Relevant changes in `proto/payment/*` `x/payment/keeper*` `x/payment/types/*` - [x] closes celestiaorg#183 Note: The constants that currently define min/max square size have not been deprecated, will do so in another PR
Adds `minSquareSize` and `maxSquareSize` as params to the payment module. Defines relevant stores and queries Relevant changes in `proto/payment/*` `x/payment/keeper*` `x/payment/types/*` - [x] closes celestiaorg#183 Note: The constants that currently define min/max square size have not been deprecated, will do so in another PR
Currently, the
MaxSquareSize
constant has to be in celestia-core, but ideally, it should be a parameter in the app. This way, it doesn't require a hardfork to change, we only need 2/3 of the voting power to vote for a proposal using the gov module.As celestia-core might need that constant and we cannot have import cycles, we can either manually mirror that parameter in celestia-core, or after we begin using ABCI++. It is possible that celestia-core will no longer need to know that constant, because the filling of the data square could happen entirely on the application side.
releated to #168
The text was updated successfully, but these errors were encountered: