Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Max and MinSquareSize as a parameter to the payment module #183

Closed
Tracked by #669
evan-forbes opened this issue Jan 12, 2022 · 3 comments · Fixed by #893
Closed
Tracked by #669

Add the Max and MinSquareSize as a parameter to the payment module #183

evan-forbes opened this issue Jan 12, 2022 · 3 comments · Fixed by #893
Assignees

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Jan 12, 2022

Currently, the MaxSquareSize constant has to be in celestia-core, but ideally, it should be a parameter in the app. This way, it doesn't require a hardfork to change, we only need 2/3 of the voting power to vote for a proposal using the gov module.

As celestia-core might need that constant and we cannot have import cycles, we can either manually mirror that parameter in celestia-core, or after we begin using ABCI++. It is possible that celestia-core will no longer need to know that constant, because the filling of the data square could happen entirely on the application side.

releated to #168

@rootulp
Copy link
Collaborator

rootulp commented Sep 20, 2022

MaxSquareSize was removed from celestia-core in celestiaorg/celestia-core#861 and added to celestia-app in #709 so this issue seems close-able.

Note: MaxSquareSize isn't a parameter to the payment module yet so @evan-forbes please re-open if that's desired.

@rootulp rootulp closed this as completed Sep 20, 2022
@evan-forbes
Copy link
Member Author

yeah, we still need to add this as a parameter. At the time of making this, it was unclear if we wanted to leave it as a constant to force a hardfork or if we want a param that can be changed by over two thirds of the voting power via the gov module. Now we want the latter.

@evan-forbes evan-forbes reopened this Sep 20, 2022
@rootulp rootulp changed the title Consider adding the MaxSquareSize as a parameter to the payment module Add the MaxSquareSize as a parameter to the payment module Sep 20, 2022
@evan-forbes
Copy link
Member Author

evan-forbes commented Oct 3, 2022

While we're at it, we should also add the min square size as a param

@evan-forbes evan-forbes changed the title Add the MaxSquareSize as a parameter to the payment module Add the Max and MinSquareSize as a parameter to the payment module Oct 3, 2022
rahulghangas added a commit that referenced this issue Nov 10, 2022
Adds `minSquareSize` and `maxSquareSize` as params to the payment
module.
Defines relevant stores and queries

Relevant changes in 
`proto/payment/*`
`x/payment/keeper*`
`x/payment/types/*`

- [x] closes #183 

Note: The constants that currently define min/max square size have not
been deprecated, will do so in another PR
rach-id pushed a commit to rach-id/celestia-app that referenced this issue Nov 16, 2022
Adds `minSquareSize` and `maxSquareSize` as params to the payment
module.
Defines relevant stores and queries

Relevant changes in
`proto/payment/*`
`x/payment/keeper*`
`x/payment/types/*`

- [x] closes celestiaorg#183

Note: The constants that currently define min/max square size have not
been deprecated, will do so in another PR
rach-id pushed a commit to rach-id/celestia-app that referenced this issue Nov 16, 2022
Adds `minSquareSize` and `maxSquareSize` as params to the payment
module.
Defines relevant stores and queries

Relevant changes in
`proto/payment/*`
`x/payment/keeper*`
`x/payment/types/*`

- [x] closes celestiaorg#183

Note: The constants that currently define min/max square size have not
been deprecated, will do so in another PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants