Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share: Periodic GC over DAGStore inside EDSStore #1116

Closed
Tracked by #1099
Wondertan opened this issue Sep 16, 2022 · 0 comments · Fixed by #1359
Closed
Tracked by #1099

share: Periodic GC over DAGStore inside EDSStore #1116

Wondertan opened this issue Sep 16, 2022 · 0 comments · Fixed by #1359
Assignees
@distractedm1nd
Labels
area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

Wondertan commented Sep 16, 2022 •
edited
Loading

Context

The EDSStore's DAGStore dependency has a GarbageCollector semantics for cleaning out removed/broken/transient Shards. In our case, it becomes more relevant after implementing #1110 but is still helpful if Shards accidentally enter the failed state.

Implementation details

Internally one goroutine periodically calls the GC method.

NOTES

Refs

Depends on #1107
Depends on #1110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@distractedm1nd distractedm1nd

Labels
area:shares Shares and samples
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(share): Periodic GC over EDSStore distractedm1nd/celestia-node
2 participants
@distractedm1nd @Wondertan