Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share/eds: Store.GetRoot #1509

Closed
Tracked by #1099
Wondertan opened this issue Dec 19, 2022 · 0 comments · Fixed by #1511
Closed
Tracked by #1099

share/eds: Store.GetRoot #1509

Wondertan opened this issue Dec 19, 2022 · 0 comments · Fixed by #1511
Assignees
@distractedm1nd
Labels
area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

We found out with @walldiss, that we can greatly simplify the ShrEx/ND protocol if the NDServer could know the full DAH. One of the approaches is to get from the header pkg, which we would like to avoid. Another idea is to get from the CAR file header which is actually stored and addressable by the DataHash that Shrex/ND relies on,
@Wondertan Wondertan added the area:shares Shares and samples label Dec 19, 2022
@renaynay renaynay changed the title shrare/eds: CARBlockstore returning DAH share/eds: CARBlockstore returning DAH Dec 19, 2022
@distractedm1nd distractedm1nd mentioned this issue Dec 19, 2022
Merged
4 tasks
@Wondertan Wondertan mentioned this issue Dec 19, 2022
Closed
45 tasks
@Wondertan Wondertan changed the title share/eds: CARBlockstore returning DAH share/eds: Store.GetRoot Dec 20, 2022
distractedm1nd added a commit that referenced this issue Dec 22, 2022
@distractedm1nd
feat(eds/store): store.GetDAH (#1511)
6179f3e 
Co-authored-by: Viacheslav <viacheslavgonkivskyi@gmail.com>
Co-authored-by: Vlad <13818348+walldiss@users.noreply.github.com>
Closes #1509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@distractedm1nd distractedm1nd

Labels
area:shares Shares and samples
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eds/store): store.GetDAH distractedm1nd/celestia-node
2 participants
@distractedm1nd @Wondertan