Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eds): WriteEDS thread safety for concurrent writingSessions #1498

Merged
merged 3 commits into from
Dec 20, 2022
Merged

fix(eds): WriteEDS thread safety for concurrent writingSessions #1498

merged 3 commits into from
Dec 20, 2022

Conversation

distractedm1nd
Copy link
Collaborator

@distractedm1nd distractedm1nd commented Dec 15, 2022 •
edited
Loading

Overview

This PR removes usage of nmt's defaultHasher to allow for concurrent writingSessions.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@distractedm1nd distractedm1nd added area:shares Shares and samples kind:fix Attached to bug-fixing PRs labels Dec 15, 2022
@distractedm1nd distractedm1nd self-assigned this Dec 15, 2022
vgonkivs
vgonkivs previously approved these changes Dec 15, 2022
View reviewed changes
Wondertan
Wondertan requested changes Dec 15, 2022
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one thing needs to be changed

share/eds/eds.go Outdated Show resolved Hide resolved
Wondertan
Wondertan previously approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

One last thing is to double check other usages of nmt.Sha256Namespace8FlaggedLeaf

@Wondertan Wondertan mentioned this pull request Dec 15, 2022
Closed
45 tasks
@distractedm1nd
Copy link
Collaborator Author

yup, checked, no other usages

walldiss
walldiss reviewed Dec 16, 2022
View reviewed changes
share/eds/eds.go Outdated Show resolved Hide resolved
vgonkivs
vgonkivs approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@vgonkivs vgonkivs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@distractedm1nd distractedm1nd merged commit d96f79e into celestiaorg:main Dec 20, 2022
@Wondertan Wondertan deleted the threadsafe-node-hashing branch December 21, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walldiss walldiss walldiss approved these changes

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@renaynay renaynay renaynay approved these changes

Assignees

@distractedm1nd distractedm1nd

Labels
area:shares Shares and samples kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@distractedm1nd @walldiss @Wondertan @vgonkivs @renaynay