feat(share/store): store eds in memory for index builder #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
added
area:shares
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Codecov Report
@@ Coverage Diff @@
## storage_performance_improvements #2409 +/- ##
====================================================================
- Coverage 53.28% 52.84% -0.44%
====================================================================
Files 156 156
Lines 9915 9995 +80
====================================================================
- Hits 5283 5282 -1
- Misses 4179 4248 +69
- Partials 453 465 +12
|
# Conflicts: # share/eds/store_test.go
walldiss
force-pushed
the
store_in_memory_index_builder
branch
from
3e4d133
to
886ccfa
Compare
distractedm1nd
suggested changes
Jun 29, 2023
# Conflicts: # share/eds/store_test.go
walldiss
force-pushed
the
store_in_memory_index_builder
branch
from
6cf5a10
to
f784a9d
Compare
Wondertan
reviewed
Jul 10, 2023
Wondertan
reviewed
Jul 10, 2023
Wondertan
previously approved these changes
Jul 14, 2023
walldiss
changed the base branch from
storage_performance_improvements
to
v0.11.0-rc9
distractedm1nd
approved these changes
Aug 2, 2023
Wondertan
approved these changes
Aug 2, 2023
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 3, 2023
…#2409) ## Overview Previously generated eds was first store to disk and then was read again while building car index for dagstore. This PR contains 2 changes: - writes eds into buffer to write it as 1 chunk instead of many small writes to disk to reduce disk i/o pressure. - introduces in-memory cache that will be used to read eds for building car index. Combined changes brings 3x performance improvement for eds.Put operation
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 4, 2023
…#2409) ## Overview Previously generated eds was first store to disk and then was read again while building car index for dagstore. This PR contains 2 changes: - writes eds into buffer to write it as 1 chunk instead of many small writes to disk to reduce disk i/o pressure. - introduces in-memory cache that will be used to read eds for building car index. Combined changes brings 3x performance improvement for eds.Put operation
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Aug 23, 2023
…#2409) ## Overview Previously generated eds was first store to disk and then was read again while building car index for dagstore. This PR contains 2 changes: - writes eds into buffer to write it as 1 chunk instead of many small writes to disk to reduce disk i/o pressure. - introduces in-memory cache that will be used to read eds for building car index. Combined changes brings 3x performance improvement for eds.Put operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously generated eds was first store to disk and then was read again while building car index for dagstore.
This PR contains 2 changes:
Combined changes brings 3x performance improvement for eds.Put operation