-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shwap): shwap nodebuilder and cleanup #3637
Conversation
nodebuilder/p2p/bitswap.go
Outdated
// TODO(@walldiss): expose cache size to cfg | ||
// default blockstore cache size | ||
defaultBlockstoreCacheSize = 128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will become part of config in different PR.
b3a0c42
to
8abec87
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shwap #3637 +/- ##
========================================
Coverage ? 46.57%
========================================
Files ? 303
Lines ? 17094
Branches ? 0
========================================
Hits ? 7962
Misses ? 8172
Partials ? 960 ☔ View full report in Codecov by Sentry. |
0d1d9a6
to
5afc24b
Compare
babc84e
to
fd2992a
Compare
This PR does a lot of things it shouldn't. It removes the old code and fixes lints. I want to express that this is an exception and we should not repeat that again. |
What title says. Likely forgotten from #3637
This PR:
There are still remaining unused code here and there that will be clean-up later. The goal of this PR is to make sure that
Are running without errors