Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shwap): shwap nodebuilder and cleanup #3637

Merged
merged 15 commits into from
Aug 15, 2024

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Aug 8, 2024

This PR:

  • add integration of all shwap modules into nodebuilder
  • Full Pruner integration (2 lines)
  • removes unused code
    • old storage related code and tests
    • old getter related code
  • fixes linter errors
  • fixes multiple tests
  • fixes edsser util

There are still remaining unused code here and there that will be clean-up later. The goal of this PR is to make sure that

  • build
  • test
  • lint
  • run
    Are running without errors

@walldiss walldiss added kind:feat Attached to feature PRs shwap labels Aug 8, 2024
@walldiss walldiss self-assigned this Aug 8, 2024
Comment on lines 30 to 28
// TODO(@walldiss): expose cache size to cfg
// default blockstore cache size
defaultBlockstoreCacheSize = 128
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will become part of config in different PR.

@walldiss walldiss force-pushed the shwap-nodebuilder branch 3 times, most recently from b3a0c42 to 8abec87 Compare August 14, 2024 12:11
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 61.49068% with 62 lines in your changes missing coverage. Please review.

Please upload report for BASE (shwap@9449437). Learn more about missing BASE report.

Files Patch % Lines
nodebuilder/share/share.go 0.00% 19 Missing ⚠️
share/shwap/p2p/bitswap/bitswap.go 40.00% 12 Missing ⚠️
libs/edssser/edssser.go 0.00% 10 Missing ⚠️
nodebuilder/share/bitswap.go 88.23% 3 Missing and 1 partial ⚠️
cmd/cel-shed/eds_store_stress.go 0.00% 3 Missing ⚠️
pruner/full/pruner.go 0.00% 3 Missing ⚠️
header/headertest/fraud/testing.go 0.00% 2 Missing ⚠️
nodebuilder/share/mocks/api.go 0.00% 2 Missing ⚠️
nodebuilder/share/module.go 92.85% 2 Missing ⚠️
store/store_cache.go 50.00% 1 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@           Coverage Diff            @@
##             shwap    #3637   +/-   ##
========================================
  Coverage         ?   46.57%           
========================================
  Files            ?      303           
  Lines            ?    17094           
  Branches         ?        0           
========================================
  Hits             ?     7962           
  Misses           ?     8172           
  Partials         ?      960           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

libs/edssser/edssser.go Show resolved Hide resolved
nodebuilder/p2p/bitswap.go Outdated Show resolved Hide resolved
nodebuilder/p2p/bitswap.go Outdated Show resolved Hide resolved
nodebuilder/share/share.go Outdated Show resolved Hide resolved
share/shwap/p2p/shrex/shrexeds/server.go Outdated Show resolved Hide resolved
nodebuilder/tests/reconstruct_test.go Outdated Show resolved Hide resolved
nodebuilder/share/constructors.go Show resolved Hide resolved
nodebuilder/share/constructors.go Outdated Show resolved Hide resolved
share/shwap/p2p/bitswap/bitswap.go Outdated Show resolved Hide resolved
share/shwap/p2p/bitswap/bitswap.go Outdated Show resolved Hide resolved
@walldiss walldiss force-pushed the shwap-nodebuilder branch 2 times, most recently from 0d1d9a6 to 5afc24b Compare August 14, 2024 16:37
share/ipld/delete_test.go Show resolved Hide resolved
share/shwap/p2p/bitswap/bitswap.go Outdated Show resolved Hide resolved
share/shwap/p2p/bitswap/bitswap.go Outdated Show resolved Hide resolved
nodebuilder/p2p/bitswap.go Outdated Show resolved Hide resolved
share/shwap/p2p/shrex/shrexeds/server.go Show resolved Hide resolved
nodebuilder/share/bitswap.go Outdated Show resolved Hide resolved
das/daser_test.go Outdated Show resolved Hide resolved
@walldiss walldiss merged commit 965f1cc into celestiaorg:shwap Aug 15, 2024
26 of 28 checks passed
@walldiss walldiss deleted the shwap-nodebuilder branch August 15, 2024 11:14
@Wondertan
Copy link
Member

This PR does a lot of things it shouldn't. It removes the old code and fixes lints. I want to express that this is an exception and we should not repeat that again.

Wondertan added a commit that referenced this pull request Oct 6, 2024
What title says.  Likely forgotten from #3637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feat Attached to feature PRs shwap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants