deps: stop using pubsub fork #887
Conversation
| github.com/libp2p/go-libp2p-core v0.17.0 | ||
| github.com/libp2p/go-libp2p-kad-dht v0.16.0 | ||
| github.com/libp2p/go-libp2p-peerstore v0.6.0 | ||
| github.com/libp2p/go-libp2p-pubsub v0.7.0 | ||
| github.com/libp2p/go-libp2p-pubsub v0.7.1-0.20220701163738-60cf38003244 |
There was a problem hiding this comment.
can we use a concrete released/tagged version?
https://github.com/libp2p/go-libp2p-pubsub/releases/tag/v0.7.1
instead of
libp2p/go-libp2p-pubsub@60cf380
There was a problem hiding this comment.
I would like to, but unfortunately no. @vyzo didn't tag a new release for all the commits in the master, and probably had reasons for that, but maybe he will change his mind ;)
There was a problem hiding this comment.
hey guys, i can tag a new release for v0.8 by week's end.
The only reason i havent rushed to it is the upgrade to depend on go-libp2p (v20), now that it has monorepoized, so i wanted to give it some bake time.
In the future pls ask when you need a release so that we can coordinate!
There was a problem hiding this comment.
Awesome, thanks for your response!
We can keep this PR open until a new pubsub release then, no rush from our side.
|
We cannot rely directly on upstream unless libp2p/go-libp2p-pubsub#497 is merged + we anyway have to wait for PubSub to be updated to v0.22.0 and so as we #1029 |
|
hey guys, I punted on a release exactly because of this.
Let me know how you want to proceed. |
|
Hey @vyzo, second option with 0.8.0 works fine for us. Still, no rush on our side. Thanks |
As
, we no longer need to rely on our fork and can directly use pubsub
This PR, also silently bumps up the libp2p patch version with a bug fix that affects us.
Closes #436