Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ABCI method needed for Fraud Proof Verification #272

Closed

Conversation

Manav-Aggarwal
Copy link
Member

@Manav-Aggarwal Manav-Aggarwal commented Aug 26, 2022

Description

Adds the following method required for Fraud Proof Verification to the ABCI interface:

VerifyFraudProof (FraudProof, expectedAppHash) → VerifiedSuccess

Also, adds a test called TestABCIEndToEndFraudProof to test out added ABCI method.

Closes: #273


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@Manav-Aggarwal Manav-Aggarwal linked an issue Aug 27, 2022 that may be closed by this pull request
@Manav-Aggarwal Manav-Aggarwal changed the title Add ABCI method for Fraud Proof Verification Add ACBI method needed for Fraud Proof Verification Aug 27, 2022
@Manav-Aggarwal Manav-Aggarwal self-assigned this Aug 27, 2022
@Manav-Aggarwal Manav-Aggarwal added the C: Cevmos Changes related to the cevmos branches label Aug 27, 2022
@Manav-Aggarwal Manav-Aggarwal marked this pull request as ready for review August 27, 2022 00:09
@Manav-Aggarwal Manav-Aggarwal changed the title Add ACBI method needed for Fraud Proof Verification feat: Add ACBI method needed for Fraud Proof Verification Aug 27, 2022
@Manav-Aggarwal Manav-Aggarwal changed the title feat: Add ACBI method needed for Fraud Proof Verification feat: Add ABCI method needed for Fraud Proof Verification Aug 27, 2022
@tzdybal
Copy link
Member

tzdybal commented Nov 7, 2022

@Manav-Aggarwal can we close this PR, as everything is moved to cosmos-sdk-rollmint repo?

@Manav-Aggarwal
Copy link
Member Author

Closed since everything is moved to cosmos-sdk-rollmint repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Cevmos Changes related to the cevmos branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ABCI method needed for Fraud Proof Verification
2 participants