Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce that chunkSize is a multiple of 64 #235

Closed
rootulp opened this issue Jul 6, 2023 · 0 comments · Fixed by #246
Closed

enforce that chunkSize is a multiple of 64 #235

rootulp opened this issue Jul 6, 2023 · 0 comments · Fixed by #246
Assignees
Labels
enhancement New feature or request

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jul 6, 2023

Context

https://github.com/rootulp/rsmt2d/blob/5661af1b27d576d5d8cf895b70230e6da4d51fb4/extendeddatasquare_test.go#L40-L43

Problem

I've observed that chunkSize must be a multiple of 64 but it's not clear to me if this invariant is enforced when importing an extended data square or computing an extended data square.

Proposal

Investigate if the invariant is enforced. I expect that rsmt2d is propagating errors from klauspost/reedsolomon if shards aren't of size 64. If that's the case, we could consider introducing a new error and verifying the data input for chunk size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant