-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test case based on celestia-node usage #239
Conversation
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 78.30% 78.30%
=======================================
Files 7 7
Lines 553 553
=======================================
Hits 433 433
Misses 73 73
Partials 47 47 |
// Populate EDS with 1/4 of chunks using SetCell | ||
err = eds.SetCell(0, 0, exampleEds.GetCell(0, 0)) | ||
require.NoError(t, err) | ||
err = eds.SetCell(0, 1, exampleEds.GetCell(0, 1)) | ||
require.NoError(t, err) | ||
err = eds.SetCell(1, 0, exampleEds.GetCell(1, 0)) | ||
require.NoError(t, err) | ||
err = eds.SetCell(1, 1, exampleEds.GetCell(1, 1)) | ||
require.NoError(t, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considered refactoring to
for row := 0; row < edsWidth/2; row++ {
for col := 0; col < edsWidth/2; col++ {
err = eds.SetCell(uint(row), uint(col), exampleEds.GetCell(uint(row), uint(col)))
require.NoError(t, err)
}
}
but I think the existing implementation is easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #238
cc: @walldiss @Wondertan