Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix lint job #2067

Merged
merged 3 commits into from
Apr 17, 2023
Merged

ci: Fix lint job #2067

merged 3 commits into from
Apr 17, 2023

Conversation

palango
Copy link
Contributor

@palango palango commented Apr 17, 2023

This switches CI to use the committed version of `golangci-lint`
@github-actions
Copy link

github-actions bot commented Apr 17, 2023

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 1ecf416

coverage: 49.9% of statements across all listed packages
coverage:  63.5% of statements in consensus/istanbul
coverage:  42.7% of statements in consensus/istanbul/announce
coverage:  55.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  61.8% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

5772 passed, 2 failed, 46 skipped

Test failures:
  TestTransactionIndices: core
    blockchain_test.go:1944: Oldest indexded block mismatch, want 0, have 69
  TestEthersJSCompatibility: e2e_test
Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000  denominator = 1000000000000000000000000 
Checking gas price minimum. cusdValue = 100000000
executing mocha test with /usr/local/bin/npm run test --networkaddr=http://127.0.0.1:33105 --blocknum=0x0 -- --grep ethers.js compatibility tests with state

ethersjs-api-check@1.0.0 test
mocha -r ts-node/register test/*.ts --grep ethers.js compatibility tests with state

ethers.js compatibility tests with state
✔ provider.getBlock works (block has gasLimit set) (63ms)
✔ EIP-1559 transactions supported (can get feeData)
✔ block has gasLimit
✔ block has baseFeePerGas

4 passing (110ms)

panic: runtime error: invalid memory address or nil pointer dereference
/opt/hostedtoolcache/go/1.17.5/x64/src/testing/testing.go:1209 +0x24e
/opt/hostedtoolcache/go/1.17.5/x64/src/testing/testing.go:1212 +0x218
/opt/hostedtoolcache/go/1.17.5/x64/src/runtime/panic.go:1038 +0x215
/home/runner/work/celo-blockchain/celo-blockchain/core/types/block.go:443 +0x30
/home/runner/work/celo-blockchain/celo-blockchain/e2e_test/e2e_test.go:510 +0x56a
/opt/hostedtoolcache/go/1.17.5/x64/src/testing/testing.go:1259 +0x102
/opt/hostedtoolcache/go/1.17.5/x64/src/testing/testing.go:1306 +0x35a

This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (bffb07d) 54.24% compared to head (2f36703) 54.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2067      +/-   ##
==========================================
+ Coverage   54.24%   54.26%   +0.02%     
==========================================
  Files         692      692              
  Lines      115618   115625       +7     
==========================================
+ Hits        62714    62745      +31     
+ Misses      49056    49033      -23     
+ Partials     3848     3847       -1     
Impacted Files Coverage Δ
accounts/abi/bind/backends/simulated.go 60.72% <0.00%> (-0.23%) ⬇️
consensus/istanbul/protocol.go 0.00% <ø> (ø)
eth/filters/api.go 43.65% <0.00%> (-0.83%) ⬇️
eth/filters/filter.go 62.14% <ø> (ø)
trie/proof.go 76.96% <ø> (+1.01%) ⬆️
trie/stacktrie.go 87.42% <ø> (ø)

... and 25 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@palango palango marked this pull request as ready for review April 17, 2023 10:16
@palango palango requested a review from carterqw2 April 17, 2023 10:17
@palango palango changed the title ci: Use go-ethereum lint configuration ci: Fix lint job Apr 17, 2023
@palango palango merged commit 1ecf416 into master Apr 17, 2023
@palango palango deleted the palango/linter2 branch April 17, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants