Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mnemonic validation flexibility within Valora #6372

Merged
merged 14 commits into from
Jan 7, 2021
Merged

Mnemonic validation flexibility within Valora #6372

merged 14 commits into from
Jan 7, 2021

Commits on Jan 6, 2021

  1. changing mnemonic logic to allow for any language recognition and to … 

    …ignore accents
    @tarikbellamine
    tarikbellamine committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    cc7a638 View commit details
    Browse the repository at this point in the history

  2. simplify validation logic

    @tarikbellamine
    tarikbellamine committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    0fc03a0 View commit details
    Browse the repository at this point in the history

  3. normalizing mnemonics and word lists to ignore accents

    @tarikbellamine
    tarikbellamine committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    737361a View commit details
    Browse the repository at this point in the history

  4. add test

    @tarikbellamine
    tarikbellamine committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    1303448 View commit details
    Browse the repository at this point in the history

  5. remove unneeded test

    @tarikbellamine
    tarikbellamine committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    ad6c727 View commit details
    Browse the repository at this point in the history

  6. pr feedback

    @tarikbellamine
    tarikbellamine committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    4ea608e View commit details
    Browse the repository at this point in the history

  7. fixing incorrectly accented words rather than stripping accents

    @tarikbellamine
    tarikbellamine committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    892ef34 View commit details
    Browse the repository at this point in the history

  8. add new tests

    @tarikbellamine
    tarikbellamine committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    2ea4e91 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. optimized functions by using a map instead of array

    @tarikbellamine
    tarikbellamine committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    ef4ef48 View commit details
    Browse the repository at this point in the history

  2. remove console logs

    @tarikbellamine
    tarikbellamine committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    126ac5a View commit details
    Browse the repository at this point in the history

  3. Lowercase mnemonic to noramlize irregular capitalizations 

    Co-authored-by: Gaston Ponti <pontigaston@gmail.com>
    @tarikbellamine @gastonponti
    tarikbellamine and gastonponti committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    0743338 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into tarikbellamine/mnemonic-accents

    @mergify
    mergify[bot] committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    41f7d63 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into tarikbellamine/mnemonic-accents

    @mergify
    mergify[bot] committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    af8aa82 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into tarikbellamine/mnemonic-accents

    @mergify
    mergify[bot] committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    027023c View commit details
    Browse the repository at this point in the history