Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: open a PR on the celo-org/docs automagically #110

Merged
merged 30 commits into from
Feb 2, 2024
Merged

CI: open a PR on the celo-org/docs automagically #110

merged 30 commits into from
Feb 2, 2024

Conversation

nicolasbrugneaux
Copy link
Contributor

@nicolasbrugneaux nicolasbrugneaux commented Jan 30, 2024 •
edited
Loading

[Blocked by celo-org/docs#1211]

[Closes #45]

This PR aims to automate updating the docs' submodule whenever the CLI gets released. This can be enlarged to more than just the CLI if the devrel team decides to use more of our generated docs.

@nicolasbrugneaux nicolasbrugneaux requested a review from a team as a code owner January 30, 2024 16:29
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 601367c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nicolasbrugneaux nicolasbrugneaux changed the title ci: first test CI: open a PR on the celo-org/docs automagically Jan 30, 2024
@nicolasbrugneaux nicolasbrugneaux changed the title CI: open a PR on the celo-org/docs automagically [WIP] CI: open a PR on the celo-org/docs automagically Jan 30, 2024
@nicolasbrugneaux nicolasbrugneaux mentioned this pull request Jan 31, 2024
Merged
@nicolasbrugneaux nicolasbrugneaux changed the title [WIP] CI: open a PR on the celo-org/docs automagically CI: open a PR on the celo-org/docs automagically Jan 31, 2024
@nicolasbrugneaux
Copy link
Contributor Author

Unblocked now that the following PR has been merged

arthurgousset
arthurgousset approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@arthurgousset arthurgousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

Interesting workflow in open-docs-pr.yml. Learnt a lot from reading it!

@nicolasbrugneaux nicolasbrugneaux merged commit 647050e into master Feb 2, 2024
17 checks passed
@nicolasbrugneaux nicolasbrugneaux deleted the ci/update-celo-docs branch February 2, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurgousset arthurgousset arthurgousset approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs.celo.org updates
3 participants
@nicolasbrugneaux @arthurgousset @pputman-clabs