Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feecurrency fixes #2

Merged
merged 9 commits into from
Oct 2, 2024
Merged

feecurrency fixes #2

merged 9 commits into from
Oct 2, 2024

Conversation

nicolasbrugneaux
Copy link
Contributor

No description provided.

@nicolasbrugneaux nicolasbrugneaux changed the title wip: use data/value for feecurrency feecurrency fixes Sep 20, 2024
@nicolasbrugneaux
Copy link
Contributor Author

Note this won't work on CI yet as a change is still necessary in web3-eth
https://github.com/web3/web3.js/blob/4.x/packages/web3-eth/src/utils/prepare_transaction_for_signing.ts#L37-L56

This need to be more flexible

Copy link

socket-security bot commented Oct 2, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/web3-eth-accounts@4.2.2-dev.cc99825.0 None +7 4.77 MB mpetrunic
npm/web3-utils@4.3.2-dev.cc99825.0 None +7 4.01 MB mpetrunic

🚮 Removed packages: npm/web3-eth-accounts@4.2.1, npm/web3-utils@4.3.1, npm/web3@4.13.0

View full report↗︎

@nicolasbrugneaux
Copy link
Contributor Author

Since web3/web3.js#7282 was merged I updated the dependencies and this is in a workable state (locally), adjusting tests and github workflows.

@nicolasbrugneaux nicolasbrugneaux merged commit c9fee6d into main Oct 2, 2024
4 of 5 checks passed
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant