Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Allow exporting metrics with resource gae_instance. #253

Merged
merged 3 commits into from
Feb 20, 2020

Conversation

imccarten1
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 20, 2020

Codecov Report

Merging #253 into master will decrease coverage by 0.08%.
The diff coverage is 82.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   72.11%   72.02%   -0.09%     
==========================================
  Files          14       17       +3     
  Lines        1646     1691      +45     
==========================================
+ Hits         1187     1218      +31     
- Misses        383      397      +14     
  Partials       76       76
Impacted Files Coverage Δ
monitoredresource/aws/aws_identity_doc_utils.go 0% <ø> (ø)
monitoredresource/gcp/gcp_metadata_config.go 0% <ø> (ø)
monitoredresource/monitored_resources.go 0% <0%> (-76.25%) ⬇️
monitoredresource/deprecated.go 100% <100%> (ø)
resource.go 100% <100%> (ø) ⬆️
monitoredresource/aws/monitored_resources.go 68.18% <68.18%> (ø)
monitoredresource/gcp/monitored_resources.go 87.03% <87.03%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddbc64a...cb016a8. Read the comment docs.

Copy link
Contributor

@rghetia rghetia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. However, can you please update resource tests in metrics_proto_api_test.go by updating
in.txt (for input) and out.txt (expected mapping) in folder

Resources
ResourcesWithMissingFields

@rghetia
Copy link
Contributor

rghetia commented Feb 20, 2020

@imccarten1 can you please also resolve the conflicts (due to #252)?

@imccarten1
Copy link
Contributor Author

I've resolved the conflicts and added gae_instance tests to the testdata in and out files.

@rghetia rghetia merged commit 1d104f7 into census-ecosystem:master Feb 20, 2020
imccarten1 added a commit to imccarten1/opencensus-go-exporter-stackdriver that referenced this pull request Feb 23, 2020
Allow exporting metrics with resource gae_instance. (census-ecosystem#253)
@msuterski
Copy link

Thanks for adding the GAE support!

I was wondering when this will get published? It's something I'm looking for for our GAE apps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants