-
Notifications
You must be signed in to change notification settings - Fork 79
Allow exporting metrics with resource gae_instance. #253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
- Coverage 72.11% 72.02% -0.09%
==========================================
Files 14 17 +3
Lines 1646 1691 +45
==========================================
+ Hits 1187 1218 +31
- Misses 383 397 +14
Partials 76 76
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. However, can you please update resource tests in metrics_proto_api_test.go by updating
in.txt (for input) and out.txt (expected mapping) in folder
@imccarten1 can you please also resolve the conflicts (due to #252)? |
Default mapping for knative_revision & autodetect labels (census-ecosystem#252)
c9fc6c2
to
cb016a8
Compare
I've resolved the conflicts and added gae_instance tests to the testdata in and out files. |
Allow exporting metrics with resource gae_instance. (census-ecosystem#253)
Thanks for adding the GAE support! I was wondering when this will get published? It's something I'm looking for for our GAE apps. |
No description provided.