This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
trace: allow for concurrent uploads to Stackdriver #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In situations where a large number of spans need to be exported from a single instance of the exporter, bundle uploads are limited to using a single goroutine. This limits the overall throughput of the exporter. Make use of the NumberOfWorkers option to allow the exporter to use multiple, concurrent goroutines to upload spans to Stackdriver. Closes census-ecosystem#245. Signed-off-by: Nick Travers <n.e.travers@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 73.19% 73.22% +0.03%
==========================================
Files 14 14
Lines 1619 1621 +2
==========================================
+ Hits 1185 1187 +2
Misses 358 358
Partials 76 76
Continue to review full report at Codecov.
|
songy23
reviewed
Jan 2, 2020
Signed-off-by: Nick Travers <n.e.travers@gmail.com>
Signed-off-by: Nick Travers <n.e.travers@gmail.com>
Signed-off-by: Nick Travers <n.e.travers@gmail.com>
|
@songy23 - thanks for the review. Should be good for another pass. |
|
@songy23 - cool to land this one? |
rghetia
approved these changes
Jan 8, 2020
|
@rghetia - thanks for merging. Any chance of a release? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where a large number of spans need to be exported from a
single instance of the exporter, bundle uploads are limited to using a
single goroutine. This limits the overall throughput of the exporter.
Make use of the NumberOfWorkers option to allow the exporter to use
multiple, concurrent goroutines to upload spans to Stackdriver.
Closes #245.
Signed-off-by: Nick Travers n.e.travers@gmail.com