This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Check .Present before setting label value #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @rghetia |
rghetia
approved these changes
Jun 23, 2020
nilebox
reviewed
Jun 24, 2020
|
@james-bebbington could you please take care of this PR if you have time? |
james-bebbington
approved these changes
Jun 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't set the labels if the value is not present.
This is necessary for the current knative work with multiple meters. In knative some metric labels are extracted into resource labels, so we shouldn't set those metric labels.
https://github.com/evankanderson/knative-pkg/blob/resourcefullest/metrics/stackdriver_exporter.go#L239