This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Skip broken gRPC streaming test #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not review this PR yet please. Our CI is broken due to the behavioral change in grpc/grpc-go@365770f. |
rakyll
force-pushed
the
tests
branch
3 times, most recently
from
5a94348
to
f555801
Compare
rakyll
force-pushed
the
tests
branch
3 times, most recently
from
cd5b632
to
e30dc52
Compare
|
We should skip this test to unblock the merge queue. |
semistrict
approved these changes
Feb 9, 2018
gRPC introduced some behavioral changes that broke OpenCensus support for streaming outgoing calls. See grpc/grpc-go#1854. In the case of a failed response, gRPC doesn't call the stats handler with the stats.End message. Given we cannot recieve the end message, we cannot finish the client span started for the streaming request. Skip this test until we figure out whether we are implementing the streaming protocol properly or gRPC introduced a bug.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC introduced some behavioral changes that broke OpenCensus support
for streaming outgoing calls.
See grpc/grpc-go#1854.
In the case of a failed response, gRPC doesn't call the stats
handler with the stats.End message. Given we cannot recieve the
end message, we cannot finish the client span started for the
streaming request.
Skip this test until we figure out whether we are implementing
the streaming protocol properly or gRPC introduced a bug.