This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
use regular thread for to expose errors in appengine #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
reviewed
Jul 29, 2019
| @@ -39,7 +39,9 @@ | |||
|
|
|||
| private IntervalMetricReader(Worker worker) { | |||
| this.worker = worker; | |||
| this.workerThread = new DaemonThreadFactory().newThread(worker); | |||
There was a problem hiding this comment.
Do we need this change? It looks to me nothing changed for JDK 8+. The previous approach only restricts JDK 7.
There was a problem hiding this comment.
Previous approach created thread using MoreExecutors.platformThreadFactory() for all JDK. We just need regular thread for logging to work.
| try { | ||
| thread.setName(threadPrefix + threadIdGen.getAndIncrement()); | ||
| thread.setDaemon(true); | ||
| } catch (SecurityException e) { |
There was a problem hiding this comment.
Is it safe to remove this try-catch clause?
There was a problem hiding this comment.
The constraints on thread renaming is from AppEngine threads. Since we are not using them it should be okay. But let me put it back as it doesn't hurt to have try-catch clause.
|
Appveyor failure is not related to this change: FAILURE: Build failed with an exception.
* What went wrong:
Could not resolve all files for configuration ':opencensus-contrib-log-correlation-log4j2:compileClasspath'.
> Could not resolve org.apache.logging.log4j:log4j-core:2.11.1.
Required by:
project :opencensus-contrib-log-correlation-log4j2
> Could not resolve org.apache.logging.log4j:log4j-core:2.11.1.
> Could not get resource 'https://repo.maven.apache.org/maven2/org/apache/logging/log4j/log4j-core/2.11.1/log4j-core-2.11.1.pom'.
> Could not GET 'https://repo.maven.apache.org/maven2/org/apache/logging/log4j/log4j-core/2.11.1/log4j-core-2.11.1.pom'.
> Connect to repo.maven.apache.org:443 [repo.maven.apache.org/151.101.184.215] failed: Connection timed out: connect |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1954 for OC+GAE (jdk8/jdk11).
Solution
Use normal thread for GAE with jdk8/jdk11. Logs generated by any thread not associated with any request are stored in memory. These logs are flushed when a next request is served.
Caveat
If no request is served or if the request is serve long after the message is logged then the message may not appear in the appengine logs. In most practical scenario, the QPS will be sufficient enough to flush these pending log messages.