Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

update guava #2018

Merged
merged 1 commit into from
Mar 11, 2020
Merged

update guava #2018

merged 1 commit into from
Mar 11, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Mar 11, 2020

@elharo elharo requested review from dinooliva, rghetia, songy23 and a team as code owners March 11, 2020 18:11
@mayurkale22
Copy link
Member

@rghetia Please review

@elharo
Copy link
Contributor Author

elharo commented Mar 11, 2020

Thanks. A code owner will need to merge.

songy23
songy23 reviewed Mar 11, 2020
View reviewed changes
build.gradle
@@ -162,7 +162,7 @@ subprojects {
findBugsJsr305Version = '3.0.2'
errorProneVersion = '2.3.2'
grpcVersion = '1.25.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double check, is this guava version compatible with grpc 1.25?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass.

@songy23 songy23 merged commit 700199c into census-instrumentation:master Mar 11, 2020
@elharo elharo mentioned this pull request Mar 11, 2020
Closed
@elharo elharo deleted the deps branch March 11, 2020 23:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@songy23 songy23 songy23 approved these changes

@rghetia rghetia rghetia approved these changes

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@dinooliva dinooliva Awaiting requested review from dinooliva

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elharo @mayurkale22 @rghetia @songy23 @googlebot