Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Load proto_library() rule. #216

Merged
merged 6 commits into from
Dec 20, 2019
Merged

Conversation

g-easy
Copy link
Contributor

@g-easy g-easy commented Dec 19, 2019

Starting with Bazel 3.0, all Protobuf rules will require explicit load
statements.

Fixes #215.

@g-easy g-easy requested a review from bogdandrutu as a code owner December 19, 2019 04:36
@g-easy
Copy link
Contributor Author

g-easy commented Dec 19, 2019

/cc @Yannic - does this look reasonable to you?

Copy link

@Yannic Yannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bogdandrutu bogdandrutu merged commit be218fb into census-instrumentation:master Dec 20, 2019
@g-easy g-easy deleted the bazel branch December 20, 2019 02:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opencensus-proto is incompatible with --incompatible_load_proto_rules_from_bzl
3 participants