-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapex 81 restrict version selection #27
Conversation
…mappings-explorer
…mappings-explorer
…er-for-threat-informed-defense/mappings-explorer into MAPEX-81-restrict-version-selection
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-81-restrict-version-selection/ |
1 similar comment
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-81-restrict-version-selection/ |
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-81-restrict-version-selection/ |
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-81-restrict-version-selection/ |
This PR has been published to https://mappingsexplorer.z13.web.core.windows.net/MAPEX-81-restrict-version-selection/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UX on this is awesome. I'm going to mark the PR as approved but I still suspect the branch needs to rebased before it can be merged.
Edit: Nevermind, Git is saying this branch can merge without conflicts. I'll do so now.
Prevent users from selecting and routing to a version combination that doesn't exist
Had to replace native html select with a javascript version so that we could have states available for the different options: