Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapex 81 restrict version selection #27

Merged
merged 26 commits into from
Dec 8, 2023

Conversation

allisonrobbins
Copy link
Contributor

Prevent users from selecting and routing to a version combination that doesn't exist

Had to replace native html select with a javascript version so that we could have states available for the different options:

  • if a valid version when combined with the current selection, the option has black text
  • if not a valid version combined with current selection, the option has gray text but is still clickable

Copy link
Contributor

github-actions bot commented Dec 5, 2023

1 similar comment
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Copy link
Contributor

@mehaase mehaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UX on this is awesome. I'm going to mark the PR as approved but I still suspect the branch needs to rebased before it can be merged.

Edit: Nevermind, Git is saying this branch can merge without conflicts. I'll do so now.

@mehaase mehaase merged commit e9c35fb into main Dec 8, 2023
3 checks passed
@mehaase mehaase deleted the MAPEX-81-restrict-version-selection branch December 8, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants