Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctor 146 escalation microsoft hyperv 2012 add option for powershell module version in node integration service mode #5080

Conversation

omercier
Copy link
Contributor

Centreon team

Description

REFS: CTOR-146

  • Modified the powershell script and the perl code to adapt nodeintegrationservices to Hyperv2022
  • Added tests with the result of the powershell script converted to JSON

Presumably fixes #4603 (to be confirmed)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

The provided tests make the perl processing work with the obtained data without the need to have an actual environment.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.

@omercier omercier force-pushed the CTOR-146-Escalation-microsoft-hyperv-2012-add-option-for-powershell-module-version-in-node-integration-service-mode branch from 404b42e to 6eeb1b1 Compare June 24, 2024 14:39
@omercier omercier marked this pull request as ready for review June 24, 2024 15:05
@omercier omercier requested review from a team as code owners June 24, 2024 15:05
@omercier omercier requested review from sdepassio and bouda1 June 24, 2024 15:05
@omercier omercier requested a review from Evan-Adam June 28, 2024 07:01
Evan-Adam
Evan-Adam previously approved these changes Jun 28, 2024
…-add-option-for-powershell-module-version-in-node-integration-service-mode
@omercier omercier dismissed stale reviews from lucie-dubrunfaut and Evan-Adam via 9b5939d July 1, 2024 07:27
@omercier omercier merged commit eca3644 into develop Jul 1, 2024
18 checks passed
@omercier omercier deleted the CTOR-146-Escalation-microsoft-hyperv-2012-add-option-for-powershell-module-version-in-node-integration-service-mode branch July 1, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants