Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Trade Finance' asset class #1337

Merged
merged 2 commits into from
May 8, 2023
Merged

'Trade Finance' asset class #1337

merged 2 commits into from
May 8, 2023

Conversation

Hornebom
Copy link
Contributor

@Hornebom Hornebom commented May 5, 2023

Description

New asset class Trade Finance for the Defactor pool
Issue: #1336

Approvals

  • Dev

@Hornebom Hornebom requested a review from onnovisser May 5, 2023 13:08
@Hornebom
Copy link
Contributor Author

Hornebom commented May 5, 2023

@onnovisser would it make sense to type the assetClass entry more specific?

@github-actions
Copy link

github-actions bot commented May 5, 2023 •
edited
Loading

PR deployed in Google Cloud
URL: https://app-pr1337.k-f.dev
Commit #: 3e45e8c
To access the functions directly check the corresponding deploy Action

@annamehr
Copy link
Contributor

annamehr commented May 5, 2023

thanks for quick fix!
Screenshot 2023-05-05 at 15 22 59

@Hornebom Hornebom merged commit 80b13a1 into main May 8, 2023
@Hornebom Hornebom deleted the feat/new-asset-class-1336 branch May 8, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onnovisser onnovisser onnovisser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hornebom @annamehr @onnovisser