Refactor MaxReserveForm #1338
Merged
Refactor MaxReserveForm #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use actual pool max reserve as initial value - enable formik to update initial value when pool params are updated -> enableReinitialize - solve ui and code being out of sync: ui displays max reserve value, but formik value is `''` (invalid number error thrown) - MaxReserveForm checks internally if for 'liquidity admin' right -> removes checks higher in the component tree - React.VFC deprecated -> React.FC
|
PR deployed in Google Cloud |
onnovisser
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
formikto update initial value when pool params are updated ->enableReinitializeformikvalue is''(invalid number error thrown -> see screenshot)MaxReserveFormchecks internally if for 'liquidity admin' right -> removes equal checks higher in the application treeApprovals
Screenshots