Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors dryRun option #1354

Merged
merged 2 commits into from
May 10, 2023
Merged

Refactors dryRun option #1354

merged 2 commits into from
May 10, 2023

Conversation

Hornebom
Copy link
Contributor

Description

  • set dryRun to false by default
  • adds debug option to toggle dryRun

Issue: #1351

Approvals

  • Dev

@Hornebom
Refactors dryRun option
ea420db 
- set dryRun to false by default
- adds debug option to toggle dryRun
@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited
Loading

PR deployed in Google Cloud
URL: https://app-pr1354.k-f.dev
Commit #: eecb9a3
To access the functions directly check the corresponding deploy Action

sophialittlejohn
sophialittlejohn approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏🙌

@Hornebom Hornebom merged commit 9f45ce1 into main May 10, 2023
@Hornebom Hornebom deleted the refactor/dryrun-use-verify-business-debug-flag-1351 branch May 10, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophialittlejohn sophialittlejohn sophialittlejohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hornebom @sophialittlejohn