Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verified | Reporting tab #1520

Merged
merged 15 commits into from
Aug 21, 2023
Merged

Conversation

Hornebom
Copy link
Contributor

@Hornebom Hornebom commented Aug 4, 2023

Description

Reset and verified version of #1384

Approvals

  • Dev

@Hornebom Hornebom mentioned this pull request Aug 4, 2023
2 tasks
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

PR deployed in Google Cloud
URL: https://app-pr1520.k-f.dev
Commit #: cd933c7
To access the functions directly check the corresponding deploy Action

@annamehr
Copy link
Contributor

annamehr commented Aug 14, 2023

@Hornebom when selecting Pool Balance it shows an error No Pool balance data available for this pool. Try to select another report or date range. but the pool has a balance of 50M.
Screenshot 2023-08-14 at 18 29 37

@annamehr
Copy link
Contributor

@Hornebom tested it again with the Apollo pool and looks like my previously reported error was related to a syncing error. The Reporting tab looks good now and can be merged.

}))
}, [loans, pool.currency.symbol])

const headers = [
Copy link
Collaborator

@onnovisser onnovisser Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headers and columns can be placed outside the component to fix this issue. or remove it from deps array

@Hornebom Hornebom merged commit 5aa1b52 into main Aug 21, 2023
8 checks passed
@Hornebom Hornebom deleted the feat/implement-design-reporting-tab--verified branch August 21, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants