Fix date for reporting #2393
Merged
Fix date for reporting #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattylucy
force-pushed
the
fix_date_reporting
branch
from
a4174d5
to
d9f76f0
Compare
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
|
Not sure if this was happening before this PR already but I just left the default date value and changed monthly to daily and am seeing the date displayed off by one. Regardless, I think it would be great to fix as part of this PR 😄 
|
Date should always be date before submitting to subquery
kattylucy
force-pushed
the
fix_date_reporting
branch
from
d9f76f0
to
83bc918
Compare
It should only show the month of the report for monthly
kattylucy
force-pushed
the
fix_date_reporting
branch
from
83bc918
to
7fa4d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date should always be date type before submitting to subquery to avoid errors
#2383