Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit pool fields #2455

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Edit pool fields #2455

merged 3 commits into from
Sep 18, 2024

Conversation

sophialittlejohn
Copy link
Collaborator

Description

This pull request...

#2435

  • adds pool structure
  • fixes rating URL not saving to IPFS
  • fixes editing of target apy
  • fixes pool name in tranche name editing
  • adds all more values to edit overview (before clicking edit)

Approvals

  • Dev

Screenshots

Impact

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

PR deployed in Google Cloud
URL: https://pr2455-app-ff-production.k-f.dev
Commit #: d6b4292
To access the functions directly check the corresponding deploy Action

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

PR deployed in Google Cloud
URL: https://app-pr2455.k-f.dev
Commit #: d6b4292
To access the functions directly check the corresponding deploy Action

kattylucy
kattylucy approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@kattylucy kattylucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophialittlejohn sophialittlejohn merged commit 70aa42c into main Sep 18, 2024
13 checks passed
@sophialittlejohn sophialittlejohn deleted the edit-pool-fields branch September 18, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattylucy kattylucy kattylucy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophialittlejohn @kattylucy