Upgrade to Polkadot-v1.7.2 #1833

lemunozm · 2024-05-09T10:55:48Z

Description

Checklist:

pallets/transfer-allowlist/src/lib.rs

pallets/restricted-tokens/src/lib.rs

lemunozm · 2024-06-06T06:04:11Z

There is a last test failing. It seems like the HostConfiguration is not applied and I do not know why: https://github.com/centrifuge/centrifuge-chain/actions/runs/9386407945/job/25846936686?pr=1833

As a fast-dirty-fix to make this work I did: 7e69e68

A better solution should be configuring the xcm part correctly. By now, I left this as debt-tech. We, anyway, need to clear and organize the 8K lines of liquidity pools, probably before starting the new features related to it

codecov · 2024-06-06T15:23:08Z

Codecov Report

Attention: Patch coverage is 5.44465% with 521 lines in your changes missing coverage. Please review.

Project coverage is 46.76%. Comparing base (2b4f94f) to head (d2072ce).

Files	Patch %	Lines
node/src/chain_spec.rs	0.00%	86 Missing ⚠️
...ntime/common/src/migrations/restricted_location.rs	0.00%	73 Missing ⚠️
runtime/common/src/migrations/hold_reason.rs	0.00%	51 Missing ⚠️
runtime/common/src/lib.rs	0.00%	47 Missing ⚠️
node/src/service.rs	0.00%	40 Missing ⚠️
pallets/restricted-tokens/src/impl_fungibles.rs	26.19%	31 Missing ⚠️
node/src/service/evm.rs	0.00%	26 Missing ⚠️
runtime/altair/src/lib.rs	0.00%	18 Missing ⚠️
runtime/centrifuge/src/lib.rs	0.00%	18 Missing ⚠️
runtime/common/src/transfer_filter.rs	0.00%	18 Missing ⚠️
... and 18 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1833      +/-   ##
==========================================
+ Coverage   46.70%   46.76%   +0.06%     
==========================================
  Files         169      169              
  Lines       13203    13169      -34     
==========================================
- Hits         6166     6159       -7     
+ Misses       7037     7010      -27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* migration for restricted transfer location * add correct location for centrifuge * minor changes * fix benchmarks * fix IT compilation * chore: extend v1.7.2 transfer location migration (#1858) * feat: add pre + post-upgrade * feat: add nuking migration for dev and demo * fix: remove account list for demo * refactor: Use `VersionedLocation` in `RestrictedTransferLocation` (#1861) * feat: add pre + post-upgrade * feat: add nuking migration for dev and demo * fix: remove account list for demo * refactor: use VersionedLocation * fix: transfer allowlist benchmarks + tests * fix: clippy * fix: benchmark cli * fix: revert tight coupling * fmt * fix IT compilation --------- Co-authored-by: William Freudenberger <w.freude@icloud.com>

lemunozm · 2024-06-06T23:48:14Z

@william could you double check the last non-checked point in the PR description? If considered checked, I think we can merge this!

mustermeiszer · 2024-06-07T07:06:10Z

runtime/altair/src/migrations.rs

@@ -23,6 +23,7 @@ pub type UpgradeAltair1035 = (
 	runtime_common::migrations::increase_storage_version::Migration<OrderBook, 0, 1>,
 	runtime_common::migrations::increase_storage_version::Migration<ForeignInvestments, 0, 1>,
 	pallet_collator_selection::migration::v1::MigrateToV1<crate::Runtime>,
+	pallet_collator_selection::migration::v2::MigrationToV2<crate::Runtime>,


Why do we have 2 migrations here? Out of curisoity?

Both needed. The first one is sorting just our invulnerables and pushing storage version from 0 to 1, the second one translates the storage entry and bumps 1 to 2.

mustermeiszer · 2024-06-07T07:19:33Z

pallets/block-rewards/src/migrations.rs

Do we still need this migraiton at all?

runtime/altair/src/xcm.rs

runtime/centrifuge/src/xcm.rs

mustermeiszer · 2024-06-07T07:43:33Z

runtime/centrifuge/src/xcm.rs

 	type SubscriptionService = PolkadotXcm;
 	type Trader = Trader;
+	type TransactionalProcessor = FrameTransactionalProcessor;


@lemunozm have you looked into the codebase what this type is doing?

It just wraps the XCM call into a transactional layer and rolls back in case of errors: https://github.com/paritytech/polkadot-sdk/blob/851c824dc7a8e7e6db2d0c9fb29d232f2f45198a/polkadot/xcm/xcm-builder/src/transactional.rs#L23

runtime/centrifuge/src/lib.rs

mustermeiszer · 2024-06-07T08:03:20Z

runtime/centrifuge/src/lib.rs

@@ -1010,6 +1056,7 @@ parameter_types! {

 	// periods between treasury spends
 	pub const SpendPeriod: BlockNumber = 14 * DAYS;
+	pub const PayoutPeriod: BlockNumber = 30 * DAYS;


Config value taken from?

Its a new parameter based on Polkadot et al. config: #1833 (comment)

runtime/altair/src/lib.rs

mustermeiszer · 2024-06-07T08:06:26Z

runtime/common/src/migrations/hold_reason.rs

+		pallet_balances::Holds::<T>::translate::<OldHolds, _>(|who, holds| {
+			if Self::account_can_be_migrated(&who, &transfer_allowlist_accounts) {
+				log::info!("{LOG_PREFIX} Migrating hold for account {who:?}");
+				let id_amount = IdAmount::<RuntimeHoldReason, Balance> {
+					id: HoldReason::TransferAllowance.into(),
+					// Non-emptiness ensured above
+					amount: holds[0].amount,
+				};
+				weight.saturating_accrue(T::DbWeight::get().reads_writes(1, 1));
+
+				Some(NewHolds::truncate_from(vec![id_amount]))
+			} else {
+				None
+			}


I hope that one is not too heavy. How many entries do we have again?

Just two on production luckily. They can only emerge from transfer allowlist for native currency. For more info, see here #1849 (comment)

wischli · 2024-06-07T09:39:04Z

@william could you double check the last non-checked point in the PR description? If considered checked, I think we can merge this!

You linked a stranger :) Sorry for the confusing Github name. It's a reference to my birth name. I am ensuring a Docker image can be build and then all checks are done!

Only thing left at this point is re-adding the DMP Queue for the lazy migration.

lemunozm · 2024-06-07T09:49:27Z

Only thing left at this point is re-adding the DMP Queue for the lazy migration.

Doing it now

wischli

Awesome work everyone! So happy we can merge this bad boy 🤘

lemunozm added Q7-very-hard Can be done by an expert coder with a deep knowledge of the codebase. I9-release A specific release. labels May 9, 2024

lemunozm requested review from cdamian and wischli May 9, 2024 10:55

lemunozm self-assigned this May 9, 2024

lemunozm requested a review from mustermeiszer as a code owner May 9, 2024 10:55

lemunozm marked this pull request as draft May 9, 2024 10:57

set dependency versions

d6e0bf4

lemunozm force-pushed the polkadot-v1.7.2 branch from f602d97 to d6e0bf4 Compare May 9, 2024 10:59

lemunozm marked this pull request as ready for review May 10, 2024 06:47

lemunozm marked this pull request as draft May 10, 2024 06:47

lemunozm added 11 commits May 10, 2024 11:34

upgrade libs/*

07bb334

upgrade pallet-anchors

446439a

upgrade pallet-fees

52d1b85

upgrade pallet-bridge

7183815

migrate simple pallets

3374bac

migrate pallet-order-book

b161119

migrated collator-allowlist & swaps

9fc71f5

upgrade rewards

f302388

upgraded pallet-mux

a38bfb6

upgrade transfer-allowlist

5ccb3d0

Merge remote-tracking branch 'origin/main' into polkadot-v1.7.2

056d942

lemunozm commented May 13, 2024

View reviewed changes

pallets/transfer-allowlist/src/lib.rs Show resolved Hide resolved

lemunozm added 2 commits May 13, 2024 13:36

fix hold reason in restricted tokens

5940897

simplify set_balance removing the holding part

7d3335f

lemunozm commented May 13, 2024

View reviewed changes

pallets/restricted-tokens/src/lib.rs Outdated Show resolved Hide resolved

upgrade restricted-xtokens

3c2bb34

lemunozm commented May 13, 2024

View reviewed changes

pallets/restricted-tokens/src/lib.rs Outdated Show resolved Hide resolved

lemunozm added 2 commits May 13, 2024 16:31

upgrade some pallets

da56ef2

upgrade pallet-ethereum-transaction

8ad0451

remove line

beb13f0

dirty fix to fix Hrmp test issue

7e69e68

lemunozm force-pushed the polkadot-v1.7.2 branch from f2b2934 to 7e69e68 Compare June 6, 2024 06:16

use default weights for treasury

1c96ae1

lemunozm marked this pull request as ready for review June 6, 2024 08:22

lemunozm requested a review from hieronx as a code owner June 6, 2024 08:22

lemunozm added 2 commits June 6, 2024 15:21

remove getrandom unused dep

7edbc3a

upgrade to last polkadot-sdk version

e1bad5f

lemunozm and others added 4 commits June 6, 2024 17:25

Merge remote-tracking branch 'origin/main' into polkadot-v1.7.2

43fbab5

fix: collator selection v2 storage migration (#1862)

dde6ca4

using latest fudge version

519e998

mustermeiszer reviewed Jun 7, 2024

View reviewed changes

protect againts crash in RtAPI

5baab79

add dmp-queue to the lazy migration, use better weights

b5a7d89

mustermeiszer previously approved these changes Jun 7, 2024

View reviewed changes

fix clippy

e7f9c27

lemunozm dismissed mustermeiszer’s stale review via e7f9c27 June 7, 2024 10:51

Merge remote-tracking branch 'origin/main' into polkadot-v1.7.2

d2072ce

wischli approved these changes Jun 7, 2024

View reviewed changes

lemunozm enabled auto-merge (squash) June 7, 2024 11:16

hieronx approved these changes Jun 7, 2024

View reviewed changes

cdamian approved these changes Jun 7, 2024

View reviewed changes

mustermeiszer approved these changes Jun 7, 2024

View reviewed changes

lemunozm merged commit ccbe93d into main Jun 7, 2024
11 of 12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Polkadot-v1.7.2 #1833

Upgrade to Polkadot-v1.7.2 #1833

lemunozm commented May 9, 2024 •

edited by wischli

Loading

lemunozm commented Jun 6, 2024 •

edited

Loading

codecov bot commented Jun 6, 2024 •

edited

Loading

lemunozm commented Jun 6, 2024

mustermeiszer Jun 7, 2024

wischli Jun 7, 2024

mustermeiszer Jun 7, 2024

wischli Jun 7, 2024

mustermeiszer Jun 7, 2024

wischli Jun 7, 2024

mustermeiszer Jun 7, 2024

wischli Jun 7, 2024

mustermeiszer Jun 7, 2024

wischli Jun 7, 2024

wischli commented Jun 7, 2024

lemunozm commented Jun 7, 2024

wischli left a comment

Upgrade to Polkadot-v1.7.2 #1833

Upgrade to Polkadot-v1.7.2 #1833

Conversation

lemunozm commented May 9, 2024 • edited by wischli Loading

Description

Checklist:

lemunozm commented Jun 6, 2024 • edited Loading

codecov bot commented Jun 6, 2024 • edited Loading

Codecov Report

lemunozm commented Jun 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wischli commented Jun 7, 2024

lemunozm commented Jun 7, 2024

wischli left a comment

Choose a reason for hiding this comment

lemunozm commented May 9, 2024 •

edited by wischli

Loading

lemunozm commented Jun 6, 2024 •

edited

Loading

codecov bot commented Jun 6, 2024 •

edited

Loading