added tests for new abi encoding features #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmxanuel
commented
Nov 6, 2018
| @@ -42,7 +42,7 @@ func TestPack(t *testing.T) { | |||
| { | |||
| "uint8[]", | |||
| []uint8{1, 2}, | |||
| common.Hex2Bytes("000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000002"), | |||
| common.Hex2Bytes("0000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000002"), | |||
| }, | |||
There was a problem hiding this comment.
for all these lines only 0000000000000000000000000000000000000000000000000000000000000020 has been added in the beginning
xmxanuel
commented
Nov 6, 2018
| }, | ||
| { | ||
|
|
||
| //web3.eth.abi.encodeParameter('bytes32[][]', [['0x0100000000000000000000000000000000000000000000000000000000000000', |
There was a problem hiding this comment.
I added the web3.js calls as a comment for easier cross checking. We can remove them later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the tests with the correct encoding for the needed types.
Currently for all dynamic arrays (int,byte,address,...) two ways are supported.
I changed the tests for all dynamic arrays to option 2 to be consistent with web3.js.
I cross-checked the encodings with latest web3.js version.
I added new tests for string[] and bytes32[][]