This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Ethers.js rewrite #187
Merged
Ethers.js rewrite #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ethers-rewrite
…o ethers-rewrite
…into ethers-rewrite
…o ethers-rewrite
Add version key
philipstanislaus
suggested changes
Sep 21, 2020
| @@ -90,13 +90,12 @@ export default class Tinlake { | |||
|
|
|||
There was a problem hiding this comment.
Can we instead make all the properties above readonly?
| // console.log(collateralNft) | ||
| // console.log(this.contract('COLLATERAL_NFT', nftAddr).functions) | ||
| // const tx = await collateralNft.issue(user, this.overrides) | ||
| // const receipt = await this.getTransactionReceipt(tx) |
There was a problem hiding this comment.
What's the reason for commenting this out?
| it('fail: does not succeed if the proxy is not approved to transfer currency from the borrower', async () => { | ||
| // create new proxy and mint collateral NFT to borrower | ||
| const proxyAddr = await borrowerTinlake.proxyCreateNew(borrowerAccount.address); | ||
| // it('fail: does not succeed if the proxy is not approved to transfer currency from the borrower', async () => { |
There was a problem hiding this comment.
What's the reason for commenting this out?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.