-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
workflow: add group_vars/defaults checks
let's use github workflow for checking defaults values. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
- Loading branch information
Showing
2 changed files
with
44 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
name: defaults | ||
on: [pull_request] | ||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
- run: "${GITHUB_WORKSPACE}/tests/scripts/workflows/defaults.sh" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
#!/bin/bash | ||
|
||
set -ex | ||
|
||
function git_diff_to_head { | ||
git diff --diff-filter=MT --no-color origin/"${GITHUB_BASE_REF}"..HEAD | ||
} | ||
|
||
function match_file { | ||
git_diff_to_head | sed -n "s|^+++.*\\($1.*\\)|\\1|p" | ||
} | ||
|
||
# group_vars / defaults | ||
match_file "/defaults/main.yml" | ||
nb=$(match_file "/defaults/main.yml" | wc -l) | ||
if [[ "$nb" -eq 0 ]]; then | ||
echo "group_vars has not been touched." | ||
else | ||
match_file "group_vars/" | ||
nb_group_vars=$(match_file "group_vars/" | wc -l) | ||
if [[ "$nb" -gt "$nb_group_vars" ]]; then | ||
echo "One or more files containing default variables has/have been modified." | ||
echo "You must run 'generate_group_vars_sample.sh' to generate the group_vars template files." | ||
exit 1 | ||
fi | ||
fi | ||
|
||
# ceph_release_num[ceph_release] statements check | ||
if match_file "roles/ceph-defaults/" | grep -E '^[<>+].*- ceph_release_num\[ceph_release\]'; then | ||
echo "Do not use statements like '- ceph_release_num[ceph_release]' in ceph-defaults role!" | ||
echo "'ceph_release' is only populated **after** the play of ceph-defaults, typically in ceph-common or ceph-docker-common." | ||
exit 1 | ||
fi | ||
echo "No '- ceph_release_num[ceph_release]' statements found in ceph-defaults role!" |