Skip to content

Commit

Permalink
update: do not gather facts on each play
Browse files Browse the repository at this point in the history
There's no benefit to gather facts again on each play in
rolling_update.yml

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 2c77d00)
  • Loading branch information
guits committed Jun 30, 2021
1 parent 5fa7102 commit f0413c4
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion infrastructure-playbooks/rolling_update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@
hosts: "{{ mon_group_name|default('mons') }}"
serial: 1
become: True
gather_facts: false
tasks:
- name: upgrade ceph mon cluster
block:
Expand Down Expand Up @@ -287,6 +288,7 @@
- name: reset mon_host
hosts: "{{ mon_group_name|default('mons') }}"
become: True
gather_facts: false
tasks:
- import_role:
name: ceph-defaults
Expand All @@ -304,6 +306,7 @@
hosts: "{{ mon_group_name|default('mons') }}"
serial: 1
become: True
gather_facts: false
tasks:
- name: upgrade mgrs when no mgr group explicitly defined in inventory
when: groups.get(mgr_group_name, []) | length == 0
Expand Down Expand Up @@ -338,6 +341,7 @@
hosts: "{{ mgr_group_name|default('mgrs') }}"
serial: 1
become: True
gather_facts: false
tasks:
# The following task has a failed_when: false
# to handle the scenario where no mgr existed before the upgrade
Expand Down Expand Up @@ -371,6 +375,7 @@
- name: set osd flags
hosts: "{{ mon_group_name | default('mons') }}[0]"
become: True
gather_facts: false
tasks:
- import_role:
name: ceph-defaults
Expand Down Expand Up @@ -398,6 +403,7 @@
hosts: "{{ osd_group_name|default('osds') }}"
serial: 1
become: True
gather_facts: false
tasks:
- name: get osd numbers - non container
shell: if [ -d /var/lib/ceph/osd ] ; then ls /var/lib/ceph/osd | sed 's/.*-//' ; fi # noqa 306
Expand Down Expand Up @@ -476,7 +482,7 @@
- name: complete osd upgrade
hosts: "{{ mon_group_name|default('mons') }}[0]"
become: True

gather_facts: false
tasks:
- import_role:
name: ceph-defaults
Expand Down Expand Up @@ -522,6 +528,7 @@
- name: upgrade ceph mdss cluster, deactivate all rank > 0
hosts: "{{ mon_group_name | default('mons') }}[0]"
become: true
gather_facts: false
tasks:
- name: deactivate all mds rank > 0
when: groups.get(mds_group_name, []) | length > 0
Expand Down Expand Up @@ -610,6 +617,7 @@
upgrade_ceph_packages: True
hosts: active_mdss
become: true
gather_facts: false
tasks:
- import_role:
name: ceph-defaults
Expand Down Expand Up @@ -655,6 +663,7 @@
upgrade_ceph_packages: True
hosts: standby_mdss
become: True
gather_facts: false

tasks:
- import_role:
Expand Down Expand Up @@ -696,6 +705,7 @@
hosts: "{{ rgw_group_name|default('rgws') }}"
serial: 1
become: True
gather_facts: false
tasks:

- import_role:
Expand Down Expand Up @@ -739,6 +749,7 @@
hosts: "{{ rbdmirror_group_name|default('rbdmirrors') }}"
serial: 1
become: True
gather_facts: false
tasks:
- name: stop ceph rbd mirror
systemd:
Expand Down Expand Up @@ -771,6 +782,7 @@
hosts: "{{ nfs_group_name|default('nfss') }}"
serial: 1
become: True
gather_facts: false
tasks:
# failed_when: false is here so that if we upgrade
# from a version of ceph that does not have nfs-ganesha
Expand Down Expand Up @@ -820,6 +832,7 @@
- "{{ iscsi_gw_group_name|default('iscsigws') }}"
serial: 1
become: True
gather_facts: false
tasks:
# failed_when: false is here so that if we upgrade
# from a version of ceph that does not have iscsi gws
Expand Down Expand Up @@ -860,6 +873,7 @@
hosts: "{{ client_group_name|default('clients') }}"
serial: "{{ client_update_batch | default(20) }}"
become: True
gather_facts: false
tasks:
- import_role:
name: ceph-defaults
Expand Down Expand Up @@ -931,6 +945,7 @@
- "{{ client_group_name | default('clients') }}"
- "{{ iscsi_gw_group_name | default('iscsigws') }}"
become: True
gather_facts: false
tasks:
- import_role:
name: ceph-defaults
Expand Down Expand Up @@ -1069,6 +1084,7 @@
- name: show ceph status
hosts: "{{ mon_group_name|default('mons') }}"
become: True
gather_facts: false
tasks:
- import_role:
name: ceph-defaults
Expand Down

0 comments on commit f0413c4

Please sign in to comment.