Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: set disableInUseChecks on rbd volume #3605

Merged
merged 1 commit into from
Jan 11, 2023
Merged

rbd: set disableInUseChecks on rbd volume #3605

merged 1 commit into from
Jan 11, 2023

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Jan 11, 2023

set disableInUseChecks on the rbd volume struct as it will be used later to check whether the rbd image is allowed to mount on multiple nodes.

fixes: #3604

Signed-off-by: Madhu Rajanna madhupr007@gmail.com

[🎩︎]mrajanna@fedora ceph-csi $]kubectl get po
NAME                          READY   STATUS    RESTARTS   AGE
pod-with-raw-block-volume     1/1     Running   0          4m11s
pod-with-raw-block-volume-1   1/1     Running   0          3m47s
[🎩︎]mrajanna@fedora ceph-csi $]kubectl get po -owide
NAME                          READY   STATUS    RESTARTS   AGE     IP            NODE           NOMINATED NODE   READINESS GATES
pod-with-raw-block-volume     1/1     Running   0          4m13s   10.244.1.20   minikube-m02   <none>           <none>
pod-with-raw-block-volume-1   1/1     Running   0          3m49s   10.244.0.12   minikube       <none>           <none>
[🎩︎]mrajanna@fedora ceph-csi $]kubectl get pvc
NAME            STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS      AGE
raw-block-pvc   Bound    pvc-391a180d-3ad9-44ad-b588-381e269324b7   1Gi        RWX            rook-ceph-block   27m

Tested manually as we dont have E2E tests for multinode.

@Madhu-1
rbd: set disableInUseChecks on rbd volume
7ec9725 
set disableInUseChecks on rbd volume struct
as it will be used later to check whether
the rbd image is allowed to mount on multiple
nodes.

fixes: ceph#3604

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@mergify mergify bot added the component/rbd Issues related to RBD label Jan 11, 2023
@Madhu-1 Madhu-1 requested review from a team January 11, 2023 12:30
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Jan 11, 2023

Looks like the regression got introduced in #2931

@nixpanic
Copy link
Member

@Madhu-1 does this need full e2e testing?

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Jan 11, 2023

@Madhu-1 does this need full e2e testing?

IMO its not required as we dont have multi-node E2E, lets run the E2E test to make sure everything works fine.

@Madhu-1 Madhu-1 added ci/retry/e2e Label to retry e2e retesting on approved PR's ok-to-test Label to trigger E2E tests labels Jan 11, 2023
@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.23

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.25

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.25

@github-actions
Copy link

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

/test ci/centos/upgrade-tests-rbd

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Jan 11, 2023

/retest ci/centos/mini-e2e/k8s-1.25

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Jan 11, 2023

/test ci/centos/upgrade-tests-rbd

@mergify mergify bot added ok-to-test Label to trigger E2E tests and removed ok-to-test Label to trigger E2E tests labels Jan 11, 2023
@mergify mergify bot merged commit d5278bd into ceph:devel Jan 11, 2023
@mergify mergify bot removed the ok-to-test Label to trigger E2E tests label Jan 11, 2023
@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.23

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.25

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.25

@github-actions
Copy link

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

/test ci/centos/upgrade-tests-rbd

@Madhu-1 Madhu-1 mentioned this pull request Jan 11, 2023
Merged
@humblec humblec added this to the release-3.8 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees
No one assigned
Labels
ci/retry/e2e Label to retry e2e retesting on approved PR's component/rbd Issues related to RBD
Projects
None yet
Milestone
release-3.8
Development

Successfully merging this pull request may close these issues.

RBD: RWX pods are not getting attached to multiple pods
4 participants
@Madhu-1 @nixpanic @Rakshith-R @humblec