Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed all potential crashing when decoding volume ID(CSI identifier) failed #4107

Closed
wants to merge 0 commits into from

Conversation

crazytaxii
Copy link
Contributor

Describe what this PR does

csi-rbdplugin will crash when decoding volume ID failed due to nil pointer, similar to #4099

Related issues

#4098 #4099

@mergify mergify bot added the bug Something isn't working label Sep 5, 2023
@nixpanic
Copy link
Member

nixpanic commented Sep 5, 2023

@Mergifyio rebase

@nixpanic nixpanic added the component/rbd Issues related to RBD label Sep 5, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2023

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/2)
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git rebase --skip'
interactive rebase in progress; onto 97df4e79
Last command done (1 command done):
   pick 4983792d rbd: fixed csi-rbdplugin crashes when decoding volume ID failed
Next command to do (1 remaining command):
   pick 813b6227 rbd: fixed potential crash if decoding volume ID failed
  (use "git rebase --edit-todo" to view and edit)
You are currently rebasing branch 'devel' on '97df4e79'.
  (all conflicts fixed: run "git rebase --continue")

nothing to commit, working tree clean
Could not apply 4983792d... rbd: fixed csi-rbdplugin crashes when decoding volume ID failed

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 6, 2023

@crazytaxii can you please squash the commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/rbd Issues related to RBD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants