Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy: update templates to v3.10.0 #4292

Merged
merged 2 commits into from
Dec 1, 2023
Merged

deploy: update templates to v3.10.0 #4292

merged 2 commits into from
Dec 1, 2023

Conversation

Rakshith-R
Copy link
Contributor

@Rakshith-R Rakshith-R commented Nov 29, 2023 •
edited
Loading

Describe what this PR does

This commit updates templates to new
v3.10.0 release.

depends-on: #4293

@Rakshith-R Rakshith-R requested review from nixpanic and a team November 29, 2023 10:45
@Rakshith-R
deploy: update templates to v3.10.0
e207761 
This commit updates templates to new
v3.10.0 release.
Pending Release Notes is also reset.

Signed-off-by: Rakshith R <rar@redhat.com>
nixpanic
nixpanic previously approved these changes Nov 29, 2023
View reviewed changes
@nixpanic nixpanic added the ci/skip/multi-arch-build skip building on multiple architectures label Nov 29, 2023
yati1998
yati1998 previously approved these changes Nov 30, 2023
View reviewed changes
@nixpanic
Copy link
Member

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023

rebase

✅ Nothing to do for rebase action

@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Nov 30, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Nov 30, 2023
@Rakshith-R @nixpanic
ci: update pr-commentor rules matrix
4e46e3b 
This commit adds rules for release-v3.10
and removes rules for release-v3.8.

Signed-off-by: Rakshith R <rar@redhat.com>
@mergify mergify bot dismissed stale reviews from nixpanic and yati1998 November 30, 2023 09:37

Pull request has been modified.

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Nov 30, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Nov 30, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@nixpanic
Copy link
Member

This is strange... even with commit 4e46e3b the pr-commenter does not want to comment in the release-v3.10 branch. The workflow file that is linked in the GitHub Action does list release-v3.10, and not release-v3.8 anymore. Probably there is something cached in some GitHub CI infrastructure that causes the old configuration for the pr-commenter to be used 🤷

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e-helm/k8s-1.26

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e/k8s-1.26

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e-helm/k8s-1.27

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e/k8s-1.27

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@riya-singhal31
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
Copy link
Member

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023

refresh

✅ Pull request refreshed

@nixpanic
Copy link
Member

/test ci/centos/k8s-e2e-external-storage/1.26

@nixpanic
Copy link
Member

/test ci/centos/k8s-e2e-external-storage/1.27

@nixpanic
Copy link
Member

/test ci/centos/k8s-e2e-external-storage/1.28

@nixpanic
Copy link
Member

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023

refresh

✅ Pull request refreshed

@nixpanic
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e/k8s-1.25

@nixpanic
Copy link
Member

/test ci/centos/mini-e2e-helm/k8s-1.25

@nixpanic
Copy link
Member

/test ci/centos/k8s-e2e-external-storage/1.25

@nixpanic
Copy link
Member

Kubernetes 1.28 does not seem to be required for release-v3.10 yet, instead it expects Kubernretes 1.25 still. That should be addressed with #4295.

@nixpanic
Copy link
Member

nixpanic commented Dec 1, 2023

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 1, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@nixpanic
Copy link
Member

nixpanic commented Dec 1, 2023

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 1, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
Copy link
Member

nixpanic commented Dec 1, 2023

I'm, trying to figure out whats wrong, but haven't found the problem yet. For some reason the base is not detected as release-v* by Mergify, all other checks have passed.

image

@nixpanic
Copy link
Member

nixpanic commented Dec 1, 2023

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 1, 2023

refresh

✅ Pull request refreshed

@nixpanic
Copy link
Member

nixpanic commented Dec 1, 2023

Trying to fix the automatic merging with #4295 . Let's refresh/requeue this PR once the configuration is updated.

@Rakshith-R
Copy link
Contributor Author

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 1, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 24ae2a7 into ceph:release-v3.10 Dec 1, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@yati1998 yati1998 yati1998 approved these changes

@riya-singhal31 riya-singhal31 riya-singhal31 approved these changes

Assignees
No one assigned
Labels
ci/skip/multi-arch-build skip building on multiple architectures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rakshith-R @nixpanic @ceph-csi-bot @riya-singhal31 @yati1998