kms: refactor functions to accept a context parameter #4477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iPraveenParihar
force-pushed
the
kms/add-context-param
branch
from
85ca2c1
to
d14a104
Compare
6 tasks
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
nixpanic
previously approved these changes
Mar 7, 2024
iPraveenParihar
changed the title
|
@Mergifyio rebase |
nixpanic
force-pushed
the
kms/add-context-param
branch
from
d14a104
to
f3b692c
Compare
✅ Branch has been successfully rebased |
Madhu-1
reviewed
Mar 12, 2024
internal/util/crypto_test.go
Outdated
| @@ -55,11 +56,12 @@ func TestKMSWorkflow(t *testing.T) { | |||
| assert.Equal(t, kms.DefaultKMSType, ve.GetID()) | |||
|
|
|||
| volumeID := "volume-id" | |||
| ctx := context.Background() | |||
iPraveenParihar
force-pushed
the
kms/add-context-param
branch
from
f3b692c
to
78c6fde
Compare
nixpanic
approved these changes
Mar 12, 2024
Madhu-1
approved these changes
Mar 12, 2024
|
@Mergifyio rebase |
Signed-off-by: Praveen M <m.praveen@ibm.com>
✅ Branch has been successfully rebased |
Rakshith-R
force-pushed
the
kms/add-context-param
branch
from
78c6fde
to
0dd3380
Compare
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at e345b26 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4476
Future concerns
Checklist:
guidelines in the developer
guide.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)