Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: pre-work for VolumeGroup support #4701

Merged
merged 4 commits into from
Jul 8, 2024
Merged

rbd: pre-work for VolumeGroup support #4701

merged 4 commits into from
Jul 8, 2024

Commits on Jul 5, 2024

  1. cleanup: pass context to rbdImage.Destroy() 

    In the future we'll introduce a more standard interface for objects like
Volumes and Snapshots. It is useful to have the context passed as 1st
argument to all functions of those objects, including their Destroy()
function.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f0e2fab View commit details
    Browse the repository at this point in the history

  2. journal: remove unused parameter journalPoolID from ReserveName() 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    459645c View commit details
    Browse the repository at this point in the history

  3. rbd: rename deleteImage() to Delete() 

    Renaming the `Delete()` function makes it easier to implement the
upcoming `Volume` interface.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    be42cc2 View commit details
    Browse the repository at this point in the history

  4. rbd: add Volume interface 

    The Volume interface will make it easier to work with the rbdImage
struct, as the functions are cleaner defined. This benefits work that is
needed for VolumeGroups and other CSI-Addons procedures.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f23dbbb View commit details
    Browse the repository at this point in the history