Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBD: improvments to existing code to better align with volumegroup #4743

Merged
merged 10 commits into from
Jul 31, 2024
Merged

RBD: improvments to existing code to better align with volumegroup #4743

merged 10 commits into from
Jul 31, 2024

Commits on Jul 31, 2024

  1. rbd: return more descriptive error 

    updated GetVolumeByID to return more
descriptive error so that caller no
need to add more details in
the error message.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1f38bed View commit details
    Browse the repository at this point in the history

  2. rbd: implement journalledObject for volumes 

    implement journalledObject interface to
return the journal objects of the volume.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1caca4d View commit details
    Browse the repository at this point in the history

  3. rbd: flatten image in CreateVolumeGroup 

    This commit adds support for flattenMode option
for volumegroup.
If the flattenMode is set to "force" in
volumegroupreplicationclass parameters,
cephcsi will add a task to flatten the image
if it has parent before adding it to the group.
This enable cephcsi to then mirror such images
after flattening them.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    223dfc4 View commit details
    Browse the repository at this point in the history

  4. rbd: add struct to error 

    updating HandleParentImageExistence function
to return more details error which includes
the pool/namespace/image name

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    807ccb9 View commit details
    Browse the repository at this point in the history

  5. vendor: update csiaddons spec 

    updating csiaddons spec to the
latest main.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e263a7d View commit details
    Browse the repository at this point in the history

  6. rbd: flatten image in ModifyVolumeGroupMembership 

    in ModifyVolumeGroupMembership RPC call,
flatten the required images before adding it
to the group or else if the parent is not
mirror enabled adding a child to the group
will fail.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    4bd7dbc View commit details
    Browse the repository at this point in the history

  7. rbd: adapt to GetVolumeByID error message 

    GetVolumeByID already returning detailed
error message, the caller just need to return
it. No need to add duplicate details to error
message.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    fd1d690 View commit details
    Browse the repository at this point in the history

  8. rbd: add context to mirror interface 

    adding required ctx to the mirror
interface as ctx is required for
the volumegroup operations.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    3d8da34 View commit details
    Browse the repository at this point in the history

  9. rbd: update group Stringer method 

    updated the group stringer method
to have pool and namespace for
proper debugging/logging and to
use it with CLI as agrument as well.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    869e14a View commit details
    Browse the repository at this point in the history

  10. rbd: add support to get volumegroupID 

    updated GetIDFromReplication to return
volumeGroupID if its present.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
    @Madhu-1
    Madhu-1 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    0f4e55d View commit details
    Browse the repository at this point in the history